341492 - ./collectstats.pl --regenerate fails

Status: RESOLVED FIXED

(Bugzilla :: Reporting/Charting, defect)

Description

[Emmanuel Seyman]

Using the current tip, I can't run "collectstats --regenerate" without it failing.
I get the following error (sorry for the foreign language) :

[manu@lora bugzilla-cvs]$ ./collectstats.pl --regenerate
Regenerating -All- [100.0%] - 00:00:00
Regenerating TestProduct [0.0%]<h1>Software error:</h1>
<pre>DBD::Pg::db selectcol_arrayref failed: ERREUR:  erreur de syntaxe sur ou près de «products» au caractère 286
 [for Statement &quot;SELECT bug_id
                          FROM bugs INNER JOIN products
                          ON bugs.product_id = products.id
                         WHERE bugs.creation_ts &lt; TO_TIMESTAMP(2453858::int, 'J')::date AND bugs.creation_ts &gt;= TO_TIMESTAMP(2453857::int, 'J')::dateAND products.name = ? ORDER BY bug_id&quot;] at ./collectstats.pl line 338
        main::regenerate_stats('./data/mining', 'TestProduct') called at ./collectstats.pl line 76
</pre>

This is caused by the "::dateAND products.name" part of the line. There should be a space between "::date" and "AND".

Comment 1

[Emmanuel Seyman]

Attachment: Include space before AND and "INNER JOIN"

Comment 2

[Frédéric Buclin]

Comment on attachment 225558 [details] [diff] [review]
Include space before AND and "INNER JOIN"

>-        $and_product = q{AND products.name = ?};
>-        $from_product = q{INNER JOIN products 
>+        $and_product = q{ AND products.name = ?};
>+        $from_product = q{ INNER JOIN products 

To make things even safer, we should add a whitespace after too (this could be done on checkin, if desired). Anyway, this looks good. r=LpSolit

Comment 3

[Frédéric Buclin]

Affects 2.24 only.

Comment 4

[Frédéric Buclin]

This is a regression due to bug 303690.

Comment 5

[Emmanuel Seyman]

(In reply to comment #2)
> 
> To make things even safer, we should add a whitespace after too (this could be
> done on checkin, if desired). Anyway, this looks good. r=LpSolit

FWIW, I'm not a big fan of this.
It hurts readability and breaks existing pratices.

Comment 6

[Frédéric Buclin]

Checking in collectstats.pl;
/cvsroot/mozilla/webtools/bugzilla/collectstats.pl,v  <--  collectstats.pl
new revision: 1.49; previous revision: 1.48
done