341495 - Merge the banner and header

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[:glob ✱]

Having both the banner and the header is redundant, they should be merged.

Comment 1

[:glob ✱]

Attachment: merge banner and header, v1

drops the banner completely and displays content that was in the header in a similar style to how the banner looked.

http://landfill.bugzilla.org/header/

Comment 2

[Frédéric Buclin]

Comment on attachment 225559 [details] [diff] [review]
merge banner and header, v1

>Index: template/en/default/global/header.html.tmpl

>+[% PROCESS "global/common-links.html.tmpl" no_find = 0 %]

Nit: "no_find = 0" is old code (in fact, the corresponding code never landed in common-links.html.tmpl) and should be removed.

Note to the one doing the checkin: banner-html.tmpl must be dropped.

r=LpSolit

Comment 3

[Frédéric Buclin]

Looks like skins/standard/global/header.png isn't required anymore. We should also remove it on checkin.

Comment 4

[Marc Schumann [:Wurblzap]]

Oh no... I use custom banner.html.tmpl a lot. If you merge them with header.html.tmpl, I'll need to use custom header.html.tmpl. Now header.html.tmpl is bound to change more often than banner.html.tmpl, so I'll have a harder time upgrading Bugzilla.

I don't like this bug :(

Comment 5

[Myk Melez [:myk] [@mykmelez]]

(In reply to comment #4)
> Oh no... I use custom banner.html.tmpl a lot. If you merge them with
> header.html.tmpl, I'll need to use custom header.html.tmpl. Now
> header.html.tmpl is bound to change more often than banner.html.tmpl, so I'll
> have a harder time upgrading Bugzilla.

This is a good point.  Installations regularly customize the Bugzilla banner, and the Bugzilla navigation bar is likely to change over time.  Putting the two together in the same template means that installations with customized banners will have to check for and merge changes between the standard template and their custom template every time they update.

Seems like we should avoid that by keeping the banner in a separate file, even as we make whatever other changes the patch is making.

Comment 6

[Frédéric Buclin]

<myk> LpSolit: i like the new UI; that's not the problem; i just want to make sure we address the issue of custom banners; perhaps you could chat with Marc (wurblzap on IRC, i think) and work out how best to support custom banners in the new UI

Comment 7

[Frédéric Buclin]

Marc, would it be enough if we let [% INCLUDE global/banner.html.tmpl %] in header.html.tmpl but clear all the text from banner.html.tmpl?

Comment 8

[Marc Schumann [:Wurblzap]]

(In reply to comment #7)

That'd make it include a custom banner.html.tmpl file, if present. So yes, I'm ok with this. Will it pass runtests.pl if you [% PROCESS %] a template which doesn't exist? (Or will you leave an empty file?)

Comment 9

[Frédéric Buclin]

(In reply to comment #8)
> ok with this. Will it pass runtests.pl if you [% PROCESS %] a template which
> doesn't exist? (Or will you leave an empty file?)

Probably we could leave it with a simple <div> </div> in it. Maybe with an id=. glob?

Comment 10

[:glob ✱]

Attachment: hidden banner

this version includes the original banner and hides with with css.

Comment 11

[:glob ✱]

Attachment: empty banner

this version includes the an empty banner.

Comment 12

[:glob ✱]

i don't know how far you intend to support customizations to bugzilla, so here's two versions for you to choose from.

for the record i prefer the original.  if you customise any opensource project, you have to expect updates to break your customisations.

Comment 13

[Frédéric Buclin]

Marc, which version do you prefer?

Comment 14

[Frédéric Buclin]

One thing I noticed: it's very hard to see the bug number (as link) in the banner when editing an attachment (the link is either dark blue or violet, and the banner itself is dark already). glob, could you please fix that?

Comment 15

[:glob ✱]

Attachment: empty banner v2

fixes links in the titles (always white now)
incorporates fix for bug 341869 (dropping h1/h2/h3)

Comment 16

[Dave Miller [:justdave]]

Um, what's the point of this, and what do we gain by doing this?

I'm still skeptical.

So does this new version basically provide an installation with no banner at all in a default install? (so you have nothing but the navigation bar and the page title at the top?)

Comment 17

[:glob ✱]

> Um, what's the point of this, and what do we gain by doing this?

screen space, flexibilty.

there's no need to have a banner that just says "this is bugzilla", when that information is already in the title.  the patch ensures that the first word of the title is always terms.bugzilla.
 
> So does this new version basically provide an installation with no banner at
> all in a default install? (so you have nothing but the navigation bar and the
> page title at the top?)

yes, but the styling of the page title matches the current banner, so you're not losing it as such.

Comment 18

[:glob ✱]

> flexibilty.

what i mean by this is right now it's hard to change the "bugzilla" text in the banner because its implemented as an image.

Comment 19

[Kevin Benton]

Comment on attachment 226106 [details] [diff] [review]
empty banner v2

(In reply to comment #12)
> i don't know how far you intend to support customizations to bugzilla, so
> here's two versions for you to choose from.
> 
> for the record i prefer the original.  if you customise any opensource project,
> you have to expect updates to break your customisations.

I agree that hiding the original code is better than removing it because new customizers appreciate an in-line example.  I also like the coding of your latest attachment.  I don't see any down side to removing the "This is Bugzilla" notice, but I am wondering why you chose to make Bugzilla look different in IE vs. FF/Moz. in some of your style statements?

Comment 20

[:glob ✱]

> Bugzilla" notice, but I am wondering why you chose to make Bugzilla look
> different in IE vs. FF/Moz. in some of your style statements?

the only change ie/ff specific change that i've introduced is using the -moz-border-radius styling (which ie doesn't support of course).

i've left any existing css selection tricks intact.

Comment 21

[Frédéric Buclin]

Bugzilla 3.0 is going to have a complete new UI. I see no reason to be compatible with current customisations.

Comment 22

[Dave Miller [:justdave]]

ok, why not?  We can screw with it again later since we're redoing UI before release anyway.

Comment 23

[:glob ✱]

Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.117; previous revision: 1.116
done
Checking in skins/standard/global.css;
/cvsroot/mozilla/webtools/bugzilla/skins/standard/global.css,v  <--  global.css
new revision: 1.22; previous revision: 1.21
done
Checking in template/en/default/index.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/index.html.tmpl,v  <--  index.html.tmpl
new revision: 1.28; previous revision: 1.27
done
Checking in template/en/default/admin/params/editparams.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/params/editparams.html.tmpl,v  <--  editparams.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/bug/show.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.html.tmpl,v  <--  show.html.tmpl
new revision: 1.13; previous revision: 1.12
done
Checking in template/en/default/global/banner.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/banner.html.tmpl,v  <--  banner.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.42; previous revision: 1.41
done

Comment 24

[Max Kanat-Alexander]

Added to the release notes on bug 255155.

Comment 25

[Max Kanat-Alexander]

The correct bug number for those release notes is actually bug 349423.

Comment 26

[[e-mail]]

Comment on attachment 226106 [details] [diff] [review]
empty banner v2

>+    #titles #title
>     {
>         font-weight: bold;
>+        white-space: nowrap;
>     }
This seems to have recreated bug 234943 for Bugzilla 3 :-(
Should I file a new bug on Bugzilla 3, or retarget the old one?

Comment 27

[:glob ✱]

> This seems to have recreated bug 234943 for Bugzilla 3 :-(

oops.

> Should I file a new bug on Bugzilla 3, or retarget the old one?

file a new bug please.