Leaking factories/modules for some components

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: jminta, Assigned: ssitter)

Tracking

unspecified
Bug Flags:
blocking-calendar1.0 +

Details

(Whiteboard: [not needed beta][no l10n impact])

Attachments

(1 obsolete attachment)

(Reporter)

Description

13 years ago
See bug 168411 comment #28.  Gavin reports that if the factory is in the same object as the module, we leak.  This is exactly how some of our component registration is done.  (see for example http://landfill.mozilla.org/mxr-test/mozilla/source/calendar/providers/caldav/calDavCalendar.js#904 )

For an example of what we should do, see http://lxr.mozilla.org/mozilla1.8/source/browser/components/search/nsSearchService.js#2290
(Reporter)

Updated

13 years ago
Whiteboard: [good first bug]
The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!
Assignee: base → nobody
(Assignee)

Comment 2

11 years ago
Created attachment 281463 [details] [diff] [review]
[checked in] define factory method outside the module, rev0
Assignee: nobody → ssitter
Status: NEW → ASSIGNED
Attachment #281463 - Flags: review?(daniel.boelzle)
(Assignee)

Updated

11 years ago
Version: Trunk → unspecified
Comment on attachment 281463 [details] [diff] [review]
[checked in] define factory method outside the module, rev0

looks good, thanks for the patch; r=dbo
Attachment #281463 - Flags: review?(daniel.boelzle) → review+
Keywords: checkin-needed
Whiteboard: [good first bug] → [good first bug][checkin-needed after 0.7]
Keywords: checkin-needed
Whiteboard: [good first bug][checkin-needed after 0.7] → [good first bug]
Attachment #281463 - Attachment description: define factory method outside the module, rev0 → [checked in] define factory method outside the module, rev0
Attachment #281463 - Attachment is obsolete: true
(Assignee)

Updated

11 years ago
Assignee: ssitter → nobody
Status: ASSIGNED → NEW
Whiteboard: [good first bug]
Is there an updated status for this bug? (I'm not sure if the patch was ever checked in...)
The patch seems to be checked in, but we do have a few locations where the factory is at least created from inside the module (i.e our createFactoryFor methods).

It would be nice to find out if this still causes a leak on 1.9.x or if it was fixed in the meanwhile.
Assignee: nobody → mschroeder
While you are at it, you could also make sure the calItemModule's module correctly implements unregisterSelf(). Seems this does no harm at the moment, but we should be future proof.
Flags: blocking-calendar1.0+
Whiteboard: [not needed beta][no l10n impact]
The rest of this is obsolete by bug 576746, marking FIXED since a patch was checked in for this bug.
Assignee: mschroeder → ssitter
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.