341538 - Missing information in XML for Time Tracking and Duplicate Bugs

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Nathan Hapke]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

We rely heavily on the xml+rdf output of bugs, after a bug is marked a duplicate of another, the resolution shows as duplicate, but it does not tell us what bug it was a duplicate of.

Also, when a user adds additional time to the time tracker and writes a comment, in the HTML output, we see the amount of time they added in-line with their comment, no such output is provided in the XML.

Reproducible: Always

Steps to Reproduce:
1. Mark a duplicate bug
2. Look at the resolution 

1. Add time to the time tracker

Actual Results:  
<bug_status>RESOLVED</bug_status>
<resolution>DUPLICATE</resolution>

and

<long_desc isprivate="0">
<who>[e-mail]</who>
<bug_when>2006-06-14 10:17:14</bug_when>
<thetext>test</thetext>
</long_desc>

Expected Results:  
<bug_status>RESOLVED</bug_status>
<resolution>DUPLICATE</resolution>
<duplicate_of>4</duplicate_of>

and

<long_desc isprivate="0">
<who>[e-mail]</who>
<bug_when>2006-06-14 10:17:14</bug_when>
<addedtime>1.5</addedtime>
<thetext>test</thetext>
</long_desc>

Version: Bugzilla 2.22

Comment 1

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Add these missing fields, based on same criteria as bug/edit.html.tmpl and bug/comment.html.tmpl

Comment 2

[Greg Hendricks]

Comment on attachment 225908 [details] [diff] [review]
Patch v1

This looks good to me. We may want to update importxml.pl to sum the work_times instead of relying on the actual_time now that we have a work_time element.

Comment 3

[Olav Vitters]

*** Bug 337627 has been marked as a duplicate of this bug. ***

Comment 4

[Frédéric Buclin]

Comment on attachment 225908 [details] [diff] [review]
Patch v1

>Index: template/en/default/bug/show.xml.tmpl

>+            [% IF UserInGroup(Param('timetrackinggroup')) &&
>+              (c.work_time > 0 || c.work_time < 0) %]

(c.work_time > 0 || c.work_time < 0) is nothing more than c.work_time alone, i.e:
[% IF UserInGroup(Param('timetrackinggroup')) && c.work_time %]

>+              <work_time>[% PROCESS formattimeunit time_unit=c.work_time FILTER xml %]</work_time>

Nit: add spaces around "=".


>+    [% IF field == "resolution" AND val == 'DUPLICATE' %]
>+      <dup_id>[% bug.dup_id FILTER xml %]</dup_id>
>+    [% END %]

Bah, what a hack! As we will soon be able to edit resolutions, one could rename it as FOO if he wants to and your trick would fail. A much better fix is to add 'bug_id' to Bugzilla::Bug::fields() right after 'resolution' and remove this hack. If a bug ID exists, it will then be displayed.

Comment 5

[Colin Ogilvie [:cso]]

Attachment: Patch v2

Fixed... note that I think the c.work_time < 0 and c.work_time > 0 are to stop a work time of "0.0" being displayed.

IF it produces a warning, edit.html.tmpl needs to be fixed, too.

Comment 6

[Frédéric Buclin]

Comment on attachment 226412 [details] [diff] [review]
Patch v2

>Index: template/en/default/bug/show.xml.tmpl

>+            [% IF UserInGroup(Param('timetrackinggroup')) && c.work_time %]
>+              <work_time>[% PROCESS formattimeunit time_unit = c.work_time FILTER xml %]</work_time>
>+            [% END %]

Nit: a workaround to avoid 0.0 to be displayed, you could write (c.work_time - 0 != 0). This will force work_time to be seen as a scalar. "c.work_time != 0" alone doesn't work. This can be fixed on checkin. r=LpSolit

Comment 7

[Colin Ogilvie [:cso]]

Fixed: 
Checking in bugzilla.dtd;
/cvsroot/mozilla/webtools/bugzilla/bugzilla.dtd,v  <--  bugzilla.dtd
new revision: 1.14; previous revision: 1.13
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.122; previous revision: 1.121
done
Checking in template/en/default/bug/show.xml.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show.xml.tmpl,v  <--  show.xml.tmpl
new revision: 1.13; previous revision: 1.12
done