341539 - Component list not filtered when a product selected on Request Queue or Edit Flag Types

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Teemu Mannermaa (:wicked)]

When a product is selected but component is left and Any/All and Filter is pressed, the resulting new form includes once again every component even though a product is selected. This happens on both Request Queue screen as well as on the Edit Flag Types screen (which recently acquired this functionality in bug 319067). Correct action is to limit components once again to those found in the selected product. User can then select a component that doesn't belong to the product and gets a nice error message about non-existing component.

Seems to be a recent regression as bmo seems to not be affected.

Comment 1

[Frédéric Buclin]

Yeah, I saw that too. Pretty annoying. But I'm not a JS expert.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Tested successfully on IE 6, IE 8, Firefox 3.5.1, Opera 10.0 beta, Safari
4.0.2, Google Chrome 2.0.172.37, and Konqueror 4.2.4.

The key point is that you have to name your form, and call document.foo, instead of document.forms[0].

Comment 3

[Frédéric Buclin]

wicked, feel free to review it too, if you have time.

Comment 4

[Frédéric Buclin]

tip:

Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.21; previous revision: 1.20
done
Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v  <--  queue.html.tmpl
new revision: 1.22; previous revision: 1.21
done


3.4:

Checking in template/en/default/admin/flag-type/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.20.2.1; previous revision: 1.20
done
Checking in template/en/default/request/queue.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/queue.html.tmpl,v  <--  queue.html.tmpl
new revision: 1.21.2.1; previous revision: 1.21
done