341554 - JS Test Library - MakeDate foo in ecma/shell.js ecma_3/Date/shell.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

Bogus NaN tests and a copy paste error it looks like:

$ cvs -z3 -q diff -u ecma/shell.js ecma_3/Date/shell.js 
Index: ecma/shell.js
===================================================================
RCS file: /cvsroot/mozilla/js/tests/ecma/shell.js,v
retrieving revision 1.12
diff -u -r1.12 shell.js
--- ecma/shell.js       3 Apr 2006 13:31:43 -0000       1.12
+++ ecma/shell.js       14 Jun 2006 19:30:19 -0000
@@ -652,13 +652,11 @@
 }
 function MakeDate( day, time ) {
   if ( day == Number.POSITIVE_INFINITY ||
-       day == Number.NEGATIVE_INFINITY ||
-       day == Number.NaN ) {
+       day == Number.NEGATIVE_INFINITY ) {
     return Number.NaN;
   }
   if ( time == Number.POSITIVE_INFINITY ||
-       time == Number.POSITIVE_INFINITY ||
-       day == Number.NaN) {
+       time == Number.NEGATIVE_INFINITY ) {
     return Number.NaN;
   }
   return ( day * msPerDay ) + time;
Index: ecma_3/Date/shell.js
===================================================================
RCS file: /cvsroot/mozilla/js/tests/ecma_3/Date/shell.js,v
retrieving revision 1.6
diff -u -r1.6 shell.js
--- ecma_3/Date/shell.js        7 Nov 2005 07:03:15 -0000       1.6
+++ ecma_3/Date/shell.js        14 Jun 2006 19:30:19 -0000
@@ -654,13 +654,11 @@
 }
 function MakeDate( day, time ) {
   if ( day == Number.POSITIVE_INFINITY ||
-       day == Number.NEGATIVE_INFINITY ||
-       day == Number.NaN ) {
+       day == Number.NEGATIVE_INFINITY ) {
     return Number.NaN;
   }
   if ( time == Number.POSITIVE_INFINITY ||
-       time == Number.POSITIVE_INFINITY ||
-       day == Number.NaN) {
+       time == Number.NEGATIVE_INFINITY ) {
     return Number.NaN;
   }
   return ( day * msPerDay ) + time;

Comment 1

[Bob Clary [:bc] (inactive)]

Checking in ecma/shell.js;
/cvsroot/mozilla/js/tests/ecma/shell.js,v  <--  shell.js
new revision: 1.13; previous revision: 1.12
done
Checking in ecma_3/Date/shell.js;
/cvsroot/mozilla/js/tests/ecma_3/Date/shell.js,v  <--  shell.js
new revision: 1.7; previous revision: 1.6
done