Tinderbox doesn't show compilation logs for modules with name containing + (as gtk+)

UNCONFIRMED
Unassigned

Status

UNCONFIRMED
12 years ago
4 years ago

People

(Reporter: jdapena, Unassigned)

Tracking

Trunk
x86
Linux

Details

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.3) Gecko/20060326 Firefox/1.5.0.3 (Debian-1.5.dfsg+1.5.0.3-2)
Build Identifier: 

I'm trying to use tinderbox to compile gnome. One of the modules is gtk+. It was breaking as no compilation was shown in the server (and other gnome modules did, providing they didn't have a slash in their names).

Reproducible: Always

Steps to Reproduce:
1. Have a gtk+ module compiling on client.
2. First compilation sent to the server creates the Build.DBdat as expected.
3. Second compilation deletes the Build.DBdat instead of adding the new information to the existing file.

Actual Results:  
Build.DBdat of gtk+ module is deleted on second compilation.

Expected Results:  
Build.DBdat of gtk+ should get incremental updates of the compilations.

I've detected the following problems:
* In processmail_builds, on filtering the build name, the sentence:
   $TINDERBOX{'buildname'} =~ s/[,;:!|\$\*\&\%\^\@\`\'\"\+]+/_/g;
could be replaced by:
   $TINDERBOX{'buildname'} =~ s/[,;:!|\$\*\&\%\^\@\`\'\"]+/_/g;

* In lib/TinderBD/BasicTxtDB, file names are not properly quoted on regex work. There are two lines doing this:
   my (@sorted_files) = sort grep ( /^$prefix/, @dir_list );
and
   my @extra_files = grep {!/^${filename}$/} @sorted_files;
They could be replaced by:
   my $quoted_prefix = quotemeta $prefix;
   my (@sorted_files) = sort grep ( /^$quoted_prefix/, @dir_list );
and
   my $quoted_filename = quotemeta $filename;
   my @extra_files = grep {!/^${quoted_filename}$/} @sorted_files;

* In lib/Utils.pm, the mask for filenames does not include the +:
   if ( $str =~ m/([0-9a-zA-Z\.\-\_\/\:]+)/ ) {
It could be replaced by:
   if ( $str =~ m/([0-9a-zA-Z\.\-\_\/\:\+]+)/ ) {

It's enough for us. Now gtk+ compilation is working in our tinderbox. Hope it helps to get it fixed.
QA Contact: kestesisme → tinderbox2
Assignee: bear → nobody
(Assignee)

Updated

4 years ago
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.