Fix bugs in selection support

RESOLVED FIXED

Status

()

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

({access})

Trunk
x86
All
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
In the current code there is some confusion between TakeSelection() and AddSelection(). TakeSelection should first clear all other selections within the same widget.

In addition, there is a naming conflict between nsIAccessible::AddSelection/RemoveSelection and the same method names in nsIAccessibleText. This makes it impossible to support both nsIAccessible and nsIAccessibleText in the same class.
(Assignee)

Comment 1

13 years ago
Created attachment 225727 [details] [diff] [review]
Tested, works
(Assignee)

Updated

13 years ago
Attachment #225727 - Attachment description: Work in progress -- builds on Windows → Tested, works
Attachment #225727 - Flags: review?(pilgrim)
(Assignee)

Comment 2

13 years ago
Created attachment 225729 [details] [diff] [review]
Addresses Mark's comments about tree items
Attachment #225729 - Flags: review?

Updated

13 years ago
Attachment #225727 - Flags: review?(pilgrim) → review-
Comment on attachment 225729 [details] [diff] [review]
Addresses Mark's comments about tree items

With additional fixes in nsXULTreeAccessible, this looks good.
Attachment #225729 - Flags: review? → review+
(Assignee)

Updated

13 years ago
Blocks: 340829
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.