341661 - change label column to tags column in thread pane

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David :Bienvenu]

We're currently displaying tags in the label column, but we really want to make it a full-fledged tags column in its own right, with sorting and grouping.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Also contains changes for Seamonkey...

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 225748 [details] [diff] [review]
proposed fix

sr=sspitzer, acting mailnews superreviewer while mscott is away

Comment 3

[David :Bienvenu]

Attachment: fix Seamonkey bustage

Comment 4

[David :Bienvenu]

Attachment: cumulative seamonkey patch

Comment 5

[David :Bienvenu]

Karsten, can you deal with the Seamonkey changes I just attached here? thx!

Comment 6

[[e-mail]]

Comment on attachment 225786 [details] [diff] [review]
cumulative seamonkey patch

>-    <treecol id="tagCol" persist="hidden ordinal width" flex="1" hidden="true"
>+    <treecol id="tagsCol" persist="hidden ordinal width" flex="1" hidden="true"
>        label="&tagColumn.label;" tooltiptext="&tagColumn.tooltip;"/>
Nit: ideally for consistency the entities would be called tagsColumn (and the line indented an extra six spaces, and the DTD changed too of course).

Comment 7

[Karsten Düsterloh]

Comment on attachment 225786 [details] [diff] [review]
cumulative seamonkey patch

r=me with Neil's suggested changes

Comment 8

[Karsten Düsterloh]

Attachment: Checked-in SM fix.

Comment 9

[Mike Cowperthwaite]

With TB 3a1-0317, I see that the Tag column in the thread pane will list all 
the tags (but crammed together with no spacing between).  There should be at least a space (or something...) between.

A tooltip showing all the tags, and maybe even some display like "(multiple)" when there are too many tags to fit, would be a nice way to avoid having to resize the columns all the time.  Also, it would be cool to display each tag name in the tag's color (altho, admittedly, possibly illegible).

I'll try to remember to open an RFE for these points.

Comment 10

[David :Bienvenu]

this is basically fixed on trunk and branch, except for Mike's last comments.

Comment 11

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620