http activity observer cleanup
Created attachment 225818 [details] [diff] [review] v1 patch cache activity distributor so we only look for it once.
Attachment #225818 - Flags: review?(cbiesinger)
Comment on attachment 225818 [details] [diff] [review] v1 patch public/nsIHttpActivityObserver.idl + * nsISupports interface for the the HTTP channel that generated this Hm... Why's this an nsISupports rather than an nsIHttpChannel? + * The value of this aActivitySubtype, will be depend on the value of This doesn't look like right english to me. Remove the comma and s/be//? + * When aActivityType is ACTIVITY_TYPE_SOCKET_TRANSPORT and + * aActivitySubtype is STATUS_SENDING_TO aExtraSizeData will contain the + * count of bytes sent There Sounds like this is missing a . + * reported for a single http transaction, each aExtraSizeData represents Since you changed HTTP to uppercase above, maybe do it here as well? + * only that portion of the total bytes sent Also missing a dot, in fact this entire block is missing them. STATUS_RECEIVING_FROM doesn't have size data? Does the REQUEST_HEADER notification come before or after the header is sent? does the size field for RESPONSE_COMPLETE include things like the chunk length lines for chunked transfer encoding? src/nsHttpTransaction.cpp + LOG((" activity distributor active\n")); you intentionally removed the logging of |this| from this statement?
Attachment #225818 - Flags: review?(cbiesinger) → review+
12 years ago
Attachment #225824 - Flags: review+
-> reassign to default owner
Assignee: darin.moz → nobody
For posterity, please see the following related bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=526207 https://bugzilla.mozilla.org/show_bug.cgi?id=488270 https://bugzilla.mozilla.org/show_bug.cgi?id=308371
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.