http activity observer cleanup

RESOLVED INCOMPLETE

Status

()

--
trivial
RESOLVED INCOMPLETE
12 years ago
3 years ago

People

(Reporter: darin.moz, Unassigned)

Tracking

Trunk
mozilla1.9alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

12 years ago
http activity observer cleanup
(Reporter)

Comment 1

12 years ago
Created attachment 225818 [details] [diff] [review]
v1 patch

cache activity distributor so we only look for it once.
Attachment #225818 - Flags: review?(cbiesinger)
(Reporter)

Updated

12 years ago
Target Milestone: --- → mozilla1.9alpha
(Reporter)

Comment 2

12 years ago
Created attachment 225824 [details] [diff] [review]
including this as well...
Comment on attachment 225818 [details] [diff] [review]
v1 patch

public/nsIHttpActivityObserver.idl
+     *   nsISupports interface for the the HTTP channel that generated this

Hm... Why's this an nsISupports rather than an nsIHttpChannel?

+     *   The value of this aActivitySubtype, will be depend on the value of

This doesn't look like right english to me. Remove the comma and s/be//?

+     * When aActivityType is ACTIVITY_TYPE_SOCKET_TRANSPORT and
+     * aActivitySubtype is STATUS_SENDING_TO aExtraSizeData will contain the
+     * count of bytes sent There

Sounds like this is missing a .

+     * reported for a single http transaction, each aExtraSizeData represents

Since you changed HTTP to uppercase above, maybe do it here as well?

+     * only that portion of the total bytes sent

Also missing a dot, in fact this entire block is missing them.

STATUS_RECEIVING_FROM doesn't have size data?

Does the REQUEST_HEADER notification come before or after the header is sent?

does the size field for  RESPONSE_COMPLETE include things like the chunk length lines for chunked transfer encoding?

src/nsHttpTransaction.cpp
+        LOG(("  activity distributor active\n"));

you intentionally removed the logging of |this| from this statement?
Attachment #225818 - Flags: review?(cbiesinger) → review+
(Reporter)

Comment 4

11 years ago
-> reassign to default owner
Assignee: darin.moz → nobody
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.