341745 - Use ROLE_ENTRY and ROLE_PASSWORD_TEXT, if available

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

Text entry and password fields should use the correct role, both for nsIAccessible and for ATK.

Comment 1

[Aaron Leventhal]

Attachment: 1) ROLE_TEXT now always means text content, 2) Move GetRole/GetExtState() to cross platform classes

Comment 2

[Aaron Leventhal]

Attachment: 1) ROLE_TEXT now always means text content, 2) Move GetRole/GetExtState() to cross platform classes

Comment 3

[Aaron Leventhal]

Attachment: Addresses Mark's comments

Comment 4

[Mark Pilgrim (inactive)]

Comment on attachment 225881 [details] [diff] [review]
Addresses Mark's comments

For the record, my objections to the previous patch were that <INPUT DISABLED> and <TEXTAREA DISABLED> were being exposed as EXT_STATE_EDITABLE.  I had questions about the single-line/multi-line handling of <TEXTAREA ROWS=1> and <TEXTAREA WRAP=OFF> but Aaron convinced me that those were being exposed properly.  (Textareas are always multi-line as far as screenreaders are concerned because you can press ENTER and get to a new line within the textarea, even if WRAP=OFF or ROWS=1.)