341795 - Strip leading and trailing spaces from bookmark keywords and tags in locationbar

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[Adam Guthrie]

Places equivalent of bug 217363.

Steps to reproduce:
1. Bookmark a page and enter "foo " for the keyword (pretend you accidentally added the extra space).
2. Type "foo" into the address bar expecting it to go to the site you just bookmarked.

Results:
I'm Feeling Lucky search or URL fixup is performed.

Expected Results:
Taken to bookmark with keyword of "foo".

This happens a lot, and is confusing, so we should just strip out the spaces.

Comment 1

[[:Aleksej]]

This bug still happens for leading spaces of keywords, and either way for tags.

Comment 2

[[:Aleksej]]

comment #1 is for Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a9pre) Gecko/2007102204 Minefield/3.0a9pre

Comment 3

[Grey Nicholson (they/them)]

How will this affect smart keywords with intentional spaces in the middle? e.g. “wtf is” (bug 304415)

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #3)
> How will this affect smart keywords with intentional spaces in the middle? e.g.
> “wtf is” (bug 304415)

That bug's patch only affected leading/trailing spaces, and strips them when setting the keyword. This bug is about porting that same 2.0 behavior to the trunk. Neither of these bugs impact keywords with spaces in the middle (though those are currently broken on the trunk due to bug 422026 - if you think they need to be fixed for Firefox 3 you should speak up there).

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Bug 422026 has a fix for this (strips leading/trailing whitespace from keywords on creation).

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 8

[Michael Kohler [:mkohler]]

(In reply to comment #5)
> Bug 422026 has a fix for this (strips leading/trailing whitespace from keywords
> on creation).

This means we would just need to do the same for tags and this bug would be fixed?

Comment 9

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.