Disable "reload" menu item when page is loading

VERIFIED INVALID

Status

Camino Graveyard
Toolbars & Menus
VERIFIED INVALID
12 years ago
12 years ago

People

(Reporter: froodian (Ian Leue), Assigned: froodian (Ian Leue))

Tracking

unspecified
Camino1.5
PowerPC
Mac OS X

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
Currently the toolbar item gets disabled, but the menu item stays enabled.
(Assignee)

Comment 1

12 years ago
Created attachment 226020 [details] [diff] [review]
Patch

Note that 90% of this is cosmetic cleanup.  The meat of the patch is 

if (action == @selector(doReload:))
    return (![[browserController getBrowserWrapper] isBusy] && ![browserController bookmarkManagerIsVisible]);
Attachment #226020 - Flags: review?(bugzilla)
(Assignee)

Comment 2

12 years ago
OK.  The real problem here is bug 304061 (rather than disable the menu item, enable the toolbar item), and the fact that reloading while a page is in the "Looking up http://foo.bar" stage does Bad Things (don't know if that's a filed bug yet).  INVALID.
(Assignee)

Updated

12 years ago
Attachment #226020 - Flags: review?(bugzilla)
(Assignee)

Updated

12 years ago
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → INVALID

Updated

12 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.