341884 - The dlgbuttons attribute of prefwindow is ignored

Status: RESOLVED WONTFIX

(Toolkit :: Preferences, defect)

Description

[Arun Ramkissoon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

I'm using the prefwindow to create the preference window for my extension. I added the attributes buttons="accept,cancel" and ondialogaccept="updateMyPrefs()". If I open the preference window of my extension only a CLOSE button is shown and the "requested" OK button is not visible. If I inspect this preference window with the DOM Inspector, I can find the requested OK button with its hidden attribute set to true. If I manually set this attribute to false the OK button becomes visible.

The behaviour above only applies for the OK and the HELP button. All other buttons (DISCLOSURE, EXTRA1 and EXTRA2) are displayed when requested.

Reproducible: Always

Steps to Reproduce:
1.Install an extension which uses for example:<prefwindow buttons="accept,cancel,help,disclosure,extra1,extra2">...</prefwindow> to visualize its preference dialog
2.open the preference dialog by selecting the extension inside the extensionmanager
3.try finding the OK or HELP button

Actual Results:  
OK and HELP button are invisible. All other buttons are displayed as expected

Expected Results:  
All five six buttons should be visible

OS: Linux 2.6.15-gentoo-r1
Windowmanager: IceWM

Comment 1

[Arun Ramkissoon]

Attachment: a small extension with only a preference dialog, to show the bug described

Comment 2

[Ryan Flint [:rflint] (ping via IRC for reviews)]

<prefwindow> has no 'buttons' attribute. You should be using 'dlgbuttons' instead. Also note that non-Windows platforms utilize instantApply. See http://developer.mozilla.org/en/docs/Preferences_System:prefwindow for more information.

Comment 3

[Arun Ramkissoon]

(In reply to comment #2)
> <prefwindow> has no 'buttons' attribute. You should be using 'dlgbuttons'
> instead. 
>
Just tried it out. When I use dlgbuttons as an attribute, no buttons are displayed at all.

Comment 5

[Dave Townsend [:mossop]]

Reopening this for further review. The dlgbuttons attribute appears to be
totally ignored in the code, there is never any attempt to show or hide the
buttons except in the standard way for the preferences dialog.

I'd say this should either be a WONTFIX based on keeping all preferences
dialogs consistent with the platform or fixed, though I'm not sure that's an
easy task given that the buttons currently depend on platform and preferences.

Comment 6

[Dave Townsend [:mossop]]

Confirming this, all platforms.

Comment 7

[muzuiget]

Firefox 20 for Linux still have this bug.

I just want to add a "help" button to my dialog, so it should doesn't matter what  'browser.preferences.instantApply' is.

`dlgbuttons="accept,help"` won't work. And use `buttons="accept,help" won't work too, alos make close button invisiable.

Comment 8

[:Gijs (he/him)]

We removed <prefwindow>.