342078 - display the "Refresh Live Title" context menu item if any bookmarks in selection have microsummaries

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Microsummaries, defect, P3)

Description

[Myk Melez [:myk] [@mykmelez]]

Per the fix for bug 341555, the "Reload Live Title" context menu item is displayed only when all items in a selection of bookmarks have microsummaries.

mconnor suggests, and I agree, that it makes sense to also display that command (and possibly others, like the "Reload Live Bookmark" command) when only some of the items in the selection have microsummaries, since users won't always be precise when choosing bookmarks to refresh, and we shouldn't enforce such precision when we can easily handle the lack of it (by refreshing the bookmarks that have microsummaries and ignoring the rest).

In theory, we would do this by making bookmarks.js's BookmarksController.isCommandEnabled() return true for cmd_bm_refreshmicrosummary if any items in the selection have microsummaries.

But BookmarksCommand.createContextMenu() extracts the intersection of enabled commands for bookmarks in the selection, so it only displays commands common to the entire selection, regardless of what isCommandEnabled() says.

We should make it possible for a command to be displayed so long as any bookmarks support it and then display the "Reload Live Title" command like that.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

And in these cases, the UI should really say:

 "Reload Live Bookmarks"
and
 "Reload Live Titles"

Comment 2

[Myk Melez [:myk] [@mykmelez]]

I suspect this of being too big a change to take into Firefox 2 at this stage.

Comment 3

[Marco Bonardo [:mak]]

- BUGSPAM -
Wontfixing all Microsummaries bugs, since the feature has been removed from the core product and previous versions won't get further fixes for it.
If interested in supporting Microsummaries in your add-on, you're free to use our old microsummaries code and to search all previously open bugs by looking for [microsummaries-feature-removal] in the status whiteboard field.