342105 - Close button not shown if there is only one tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Pradeep Kumar]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060526 BonEcho/2.0a3

Close button is not shown on the tab if there is only one tab open with the option  "Hide the tab bar when only one website is open" is turned off.

Reproducible: Always

Steps to Reproduce:
1.Test with a fresh profile. Launch Bon Echo
2.Go to Tools ->Options ->Tabs ->Uncheck "Hide the tab bar when only one website is open" checkbox
3.Keep only one tab open.

Actual Results:  
Shows a tabbar without the X close button. Shows the "close tab" option on the tabbar context menu though.

Expected Results:  
Should show the X close button. Clicking on which should clear the tab content, the equivalent of context menu "close tab" option.

Comment 1

[Pradeep Kumar]

Attachment: Shows that the close button missing for a single tab.

Comment 2

[jiri slaby]

Me too, on Linux.

Comment 3

[Pradeep Kumar]

I would like to add the close button is missing on the end of the tabbar also. So the only way to close is to use the tabbar context menu.

Comment 4

[Tracy Walker [:tracy]]

confirmed, upgraded severity, changed platform/OS to all and requested 2.0 blocking flag.

Seeing this on Firefox 2.0 beta 1 on Mac and Windows.  Bug Day topic for 07/11 is 2.0 Tabbed Browsing.  I will put the community on finding the regression window.

Note:  oddly enough, if you use the context menu to close the only open tab, the tab becomes (Untitled) as expected and gains the close button which it retains even after browsing in that tab.  But if you open another tab and close it the Single remaining tab loses its close button again.  Perhaps this is intentional, to protect the user from inadvertantly destroying that tabs history??  If so please mark this bug invalid.

Comment 5

[Tracy Walker [:tracy]]

possibly related to bug 343422

Comment 6

[Pradeep Kumar]

(In reply to comment #4)
> Note:  oddly enough, if you use the context menu to close the only open tab,
> the tab becomes (Untitled) as expected and gains the close button which it
> retains even after browsing in that tab.  But if you open another tab and close
> it the Single remaining tab loses its close button again.  Perhaps this is
> intentional, to protect the user from inadvertantly destroying that tabs
> history??  If so please mark this bug invalid.
> 
I am not able to get the close button again in the manner you mentioned. But I did notice that the tab had retained its history even though it has been closed(not sure if this is the expected behavior) anyone?
If the case was to prevent the user from losing the tab history then even the context menu option should have been disabled??.
But that would leave no way to clear the last tab.

Comment 7

[Simon Bünzli]

Mike: with bug 281012 fixed, it might be worth reconsidering always showing the close button (opposite to what Opera does; don't know about IE7b3). Or do you think it's too confusing that when you close a tab a new one replaces it (instead of showing no tab at all or closing the window which we both can't do/don't want)?

(In reply to comment #5)
> possibly related to bug 343422
That bug is responsible for the cases when it's actually shown - which it currently isn't expected to at all.

(In reply to comment #6)
You seem to be using Firefox 1.5.0.*. We're talking about the current development versions.

Comment 8

[Pradeep Kumar]

> (In reply to comment #6)
> You seem to be using Firefox 1.5.0.*. We're talking about the current
> development versions.
> 
I am seeing this issue on Bon Echo/2.0a3 as mentioned in my original report. Maybe it has changed after that.I dont know about that.

Comment 9

[Simon Bünzli]

(In reply to comment #8)
Sorry. But please do know, since this has changed with the fix to bug 281012 on 2006-06-06. And while this might be a major issue to you, this might just as well be no issue at all (if it is decided to stick to the current behavior, this bug will become WONTFIXed).

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

The close button should be shown, with the effect being that it disposes the tab and immediately opens a new one. Strange behaviour surely, but I think it's the easiest and most reliably understandable case.

Comment 11

[Mike Connor [:mconnor]]

*** Bug 343422 has been marked as a duplicate of this bug. ***

Comment 12

[tommyjb]

"uiwanted" just disappeared from Keywords.  BugZilla bug?

Comment 13

[Simon Bünzli]

Attachment: don't treat a single tab in a special way

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #12)
> "uiwanted" just disappeared from Keywords.  BugZilla bug?

No, I submitted the ui design in comment 10, and removed the keyword.

Comment 15

[(not reading, please use [e-mail] instead)]

note, asaf has just touched this code, so there's going to be some bitrot on that patch.

Comment 16

[(not reading, please use [e-mail] instead)]

Comment on attachment 229158 [details] [diff] [review]
don't treat a single tab in a special way

actually, I don't see any bit rot. 

the patch looks good, so I'm testing it now.

thanks for the patch!

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 229158 [details] [diff] [review]
don't treat a single tab in a special way

r=sspitzer, seeking sr= from mconnor.

Comment 18

[Mike Connor [:mconnor]]

Comment on attachment 229158 [details] [diff] [review]
don't treat a single tab in a special way

So, I don't know what error either, and this might be a legacy piece from where I relocated a bunch of that code, but without knowing for sure, let's leave it in on branch (Simon, can you file a followup on this, with the goal of removing the try/catch)

Comment 19

[(not reading, please use [e-mail] instead)]

I'll do the check in and log the spin off bug.

Comment 20

[(not reading, please use [e-mail] instead)]

fixed on the trunk.

> (Simon, can you file a followup on this, with the goal of removing
> the try/catch)

see bug #345561

Comment 21

[(not reading, please use [e-mail] instead)]

Comment on attachment 229158 [details] [diff] [review]
don't treat a single tab in a special way

seeking a= for branch

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 229158 [details] [diff] [review]
don't treat a single tab in a special way

a=drivers. Please go ahead and land this on the MOZILLA_1_8_BRANCH.

Comment 23

[(not reading, please use [e-mail] instead)]

fixed on the branch.

Simon, thanks again for the fix!

Comment 24

[Ria Klaassen (not reading all bugmail)]

*** Bug 349840 has been marked as a duplicate of this bug. ***

Comment 25

[Ria Klaassen (not reading all bugmail)]

*** Bug 350412 has been marked as a duplicate of this bug. ***