/intl/uconv/idl/nsICharsetConverterManager.idl, line 53 -- // XXX change to NS_CHARSETCONVERTERMANAGER_PID 54 #define NS_CHARSETCONVERTERMANAGER_CONTRACTID "@mozilla.org/charset-converter-manager;1"
Created attachment 8344281 [details] [diff] [review] bug342135_v1.patch
Attachment #8344281 - Flags: review?(VYV03354)
Attachment #8344281 - Flags: review?(VYV03354) → review+
Thanks for the review.
Assignee: smontagu → cykesiopka.bmo
Summary: remove stale comment → Remove stale comments in nsICharsetConverterManager.idl
The first of the comments you are removing seems valid -- CIDs are for classes, not interfaces, so the name of the CID is wrong.
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3) > The first of the comments you are removing seems valid -- CIDs are for > classes, not interfaces, so the name of the CID is wrong. Ok, thanks for catching that!
Created attachment 8344309 [details] [diff] [review] bug342135_v2.patch - Revert removal of first comment Just reverting the removal of one comment, so carrying forward r+.
Attachment #8344281 - Attachment is obsolete: true
Summary: Remove stale comments in nsICharsetConverterManager.idl → Remove stale comment in nsICharsetConverterManager.idl
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
You need to log in before you can comment on or make changes to this bug.