Closed Bug 342135 Opened 14 years ago Closed 6 years ago

Remove stale comment in nsICharsetConverterManager.idl

Categories

(Core :: Internationalization, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: timeless, Assigned: Cykesiopka)

References

()

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

/intl/uconv/idl/nsICharsetConverterManager.idl, line 53 -- // XXX change to NS_CHARSETCONVERTERMANAGER_PID
  54 #define NS_CHARSETCONVERTERMANAGER_CONTRACTID "@mozilla.org/charset-converter-manager;1"
QA Contact: amyy → i18n
Attached patch bug342135_v1.patch (obsolete) — Splinter Review
Attachment #8344281 - Flags: review?(VYV03354)
Attachment #8344281 - Flags: review?(VYV03354) → review+
Thanks for the review.
Assignee: smontagu → cykesiopka.bmo
Keywords: checkin-needed
Summary: remove stale comment → Remove stale comments in nsICharsetConverterManager.idl
The first of the comments you are removing seems valid -- CIDs are for classes, not interfaces, so the name of the CID is wrong.
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3)
> The first of the comments you are removing seems valid -- CIDs are for
> classes, not interfaces, so the name of the CID is wrong.

Ok, thanks for catching that!
Keywords: checkin-needed
- Revert removal of first comment

Just reverting the removal of one comment, so carrying forward r+.
Attachment #8344281 - Attachment is obsolete: true
Keywords: checkin-needed
Summary: Remove stale comments in nsICharsetConverterManager.idl → Remove stale comment in nsICharsetConverterManager.idl
https://hg.mozilla.org/mozilla-central/rev/e5edb615c64f
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.