Remove stale comment in nsICharsetConverterManager.idl

RESOLVED FIXED in mozilla28

Status

()

Core
Internationalization
--
trivial
RESOLVED FIXED
12 years ago
4 years ago

People

(Reporter: timeless, Assigned: Cykesiopka)

Tracking

Trunk
mozilla28
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

12 years ago
/intl/uconv/idl/nsICharsetConverterManager.idl, line 53 -- // XXX change to NS_CHARSETCONVERTERMANAGER_PID
  54 #define NS_CHARSETCONVERTERMANAGER_CONTRACTID "@mozilla.org/charset-converter-manager;1"
QA Contact: amyy → i18n
(Assignee)

Comment 1

4 years ago
Created attachment 8344281 [details] [diff] [review]
bug342135_v1.patch
Attachment #8344281 - Flags: review?(VYV03354)
Attachment #8344281 - Flags: review?(VYV03354) → review+
(Assignee)

Comment 2

4 years ago
Thanks for the review.
Assignee: smontagu → cykesiopka.bmo
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Summary: remove stale comment → Remove stale comments in nsICharsetConverterManager.idl
The first of the comments you are removing seems valid -- CIDs are for classes, not interfaces, so the name of the CID is wrong.
(Assignee)

Comment 4

4 years ago
(In reply to David Baron [:dbaron] (needinfo? me) (UTC-8) from comment #3)
> The first of the comments you are removing seems valid -- CIDs are for
> classes, not interfaces, so the name of the CID is wrong.

Ok, thanks for catching that!
Keywords: checkin-needed
(Assignee)

Comment 5

4 years ago
Created attachment 8344309 [details] [diff] [review]
bug342135_v2.patch

- Revert removal of first comment

Just reverting the removal of one comment, so carrying forward r+.
Attachment #8344281 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
Summary: Remove stale comments in nsICharsetConverterManager.idl → Remove stale comment in nsICharsetConverterManager.idl
https://hg.mozilla.org/mozilla-central/rev/e5edb615c64f
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28

Updated

4 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.