342167 - In <EditorOverride.css>, 2 "Warning: Expected pseudo-element but found '-moz-XYZ'. Ruleset ignored due to bad selector."

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060618 SeaMonkey/1.1a] (nightly) (W98SE) [2006-06-18-15-mozilla1.8]

No warnings.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060620 SeaMonkey/1.1a] (nightly) (W98SE) [2006-06-20-03-mozilla1.8]

First time clicking 'Reply' in a session:
[[
Warning: Expected pseudo-element but found '-moz-canvas'.  Ruleset ignored due to bad selector.
Source File: resource:///res/EditorOverride.css
Line: 47

Warning: Expected pseudo-element but found '-moz-display-comboboxcontrol-frame'.  Ruleset ignored due to bad selector.
Source File: resource:///res/EditorOverride.css
Line: 113
]]

"You are not authorized to access bug #331883." could be the cause !?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Hmm. This should not be happening. It's definitely bug 331883.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I changed the wrong function when merging to branch. I changed ReplaceStyleSheet when I should have changed AddOverrideStyleSheet. D'oh! I'll fix this tomorrow.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Fixed busted merge to branch. This is a really simple fix. I guess it fixes a regression in HTML editing although I'm not really sure what the user--visible consequences are. We should get this regression fixed before we ship 1.8.0.5.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This should block 1.8.0.5 because it's regression since 1.8.0.4.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 226558 [details] [diff] [review]
fix

Probably better if you don't drop the comment, but r+sr=dbaron.

Comment 6

[Daniel Veditz [:dveditz]]

Would have been nice to get non-critical regressions nominated a lot earlier in the cycle, but looks safe enough

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 226558 [details] [diff] [review]
fix

approved for 1.8.0 branch, a=dveditz for drivers

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This was only reported two days ago (thanks Serge!). The comment you added in the status whiteboard "(fixed in 1.8.0.4)" is actually incorrect, 331883 was fixed on branch for 1.8.0.5 on the 18th.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in on branches.

Comment 10

[Adam Guthrie]

Verified FIXED using Thunderbird version 1.5.0.5 (20060622). 

Using the build Serge mentioned I saw the errors, then I downloaded a recent build with the patch in it and saw no errors.

Comment 11

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060622 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH, between these two builds.

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060623 SeaMonkey/1.1a] (nightly) (W98SE)