342200 - Remove nsSVGPathGeometryFrame subclasses

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[tor]

Comment 1

[tor]

Attachment: remove most subclasses; nsSVGImageFrame left

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

GetMarkPoints could take an nsTArray of nsSVGMarks, but I'll let that go for now...

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Maybe we could share code between polygon and polyline elements, perhaps by sticking a flag somewhere to indicate whether it's closed or not.

Comment 4

[tor]

Checked in.

Bug 342301 and bug 342302 filed for following up on the suggestions.

Comment 5

[Robert Longson [:longsonr]]

Unfortunately this seems to break textPath.

nsSVGTextPathFrame::GetFlattenedPath expects to find a referenced frame of type nsGkAtoms::svgPathFrame otherwise it returns nsnull.

Referenced frames are now of type nsLayoutAtoms::svgPathGeometryFrame. Changing the test in GetFlattenedPath makes textPath elements display again but it's not ideal as the content could be anything derived from nsSVGPathGeometryElement and not necessarily an nsSVGPathElement. I guess the GetFlattenedPath in nsSVGPathElement method needs to exist in nsSVGPathGeometryElement, become virtual return nsnull and be overridden in nsSVGPathElement, then you can cast the content to an nsSVGPathGeometryElement.

Comment 6

[tor]

Thanks for picking up on that - I've filed bug 342542 for fixing the regression.