342212 - Installation of microsummary with long name (attribute) fails

Status: RESOLVED FIXED

(Firefox Graveyard :: Microsummaries, defect, P1)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1a3) Gecko/20060620 BonEcho/2.0a3

Steps to reproduce:
1. Open testcase.
2. Click the Install microsummary generator link.

Results:
No generator installed.

Expected results:
Microsummary generator should be installed.

I get this error in the Error Console:
Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIFile.createUnique]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///[snip]/components/nsMicrosummaryService.js :: anonymous :: line 381"  data: no]
Source File: file:///[snip]/components/nsMicrosummaryService.js
Line: 381

I think the best thing to do would be to just fix sanitizeName to truncate the name.

Comment 1

[Adam Guthrie]

Attachment: microsummary generator

Comment 2

[Adam Guthrie]

Attachment: testcase

Comment 3

[Joey Minta]

Attachment: truncate at 60

I really don't have a good feel for where we should truncate these names, but my theory was 60 + createUnique can generally stay under 64, which is a nice magic number in the computer world.  I'm open to suggestions for better values though.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 229852 [details] [diff] [review]
truncate at 60

Note that all three tier 1 platforms support filenames up to 255 characters long, although for Windows the entire path must fit within that limit, according to the following page.

http://linuxboxadmin.com/articles/filefriction.php

Given the funky Windows behavior, a 64 character limit seems reasonable.

Patch looks good, works well. r=myk

Thanks for the fix!

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checked in to the trunk.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 229852 [details] [diff] [review]
truncate at 60

Notes for drivers considering this approval request:

This fixes an edge case in which we fail to install microsummary generators.  The fix is trivial and presents a low risk of regressions.  It has been on the trunk since Thursday early morning.

Comment 7

[Mike Connor [:mconnor]]

Comment on attachment 229852 [details] [diff] [review]
truncate at 60

a=mconnor on behalf of drivers for checkin to the 1.8 branch