Fall back on localURI if a local microsummary generator has no sourceURI

RESOLVED FIXED in Firefox 2 beta1

Status

P3
normal
RESOLVED FIXED
13 years ago
3 years ago

People

(Reporter: zeniko, Assigned: zeniko)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 beta1
fixed1.8.1

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
... for all those developers who prefer not to have to make up a fake URL when testing generators locally. Of course, updating a generator where sourceURI.equals(localURI) won't make sense, but preventing that shouldn't be an issue...
(Assignee)

Comment 1

13 years ago
Created attachment 226431 [details] [diff] [review]
fix

This fix is simpler than I thought. Am I missing something?
Attachment #226431 - Flags: review?(myk)
Comment on attachment 226431 [details] [diff] [review]
fix


This seems reasonable, the code looks good, and it works fine.  Note that we'll not want this functionality to trickle out into production generators, but we should be able to do that by making sure we continue to write the source URI into generators we install before we write them to disk.
Attachment #226431 - Flags: review?(myk)
Attachment #226431 - Flags: review+
Attachment #226431 - Flags: approval1.8.1?
Comment on attachment 226431 [details] [diff] [review]
fix

Per mconnor's blog post (http://steelgryphon.com/blog/?p=81), removing approval request until patch has landed on the trunk, baked, and has justification for landing on the branch for beta1.
Attachment #226431 - Flags: approval1.8.1?
Assignee: nobody → zeniko
Checked in to trunk.  Holding branch checkin per beta1 branch lockdown.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Comment on attachment 226431 [details] [diff] [review]
fix

This was checked into the trunk a week ago, and it doesn't seem to have caused any problems there.  It's not a critical fix, but it's a useful one for developers, who will be a disproportionately high percentage of initial microsummary consumers, so it'd be good to get it on the branch, which is where those developers will likely initially encounter the feature.  It presents a low risk of regression.
Attachment #226431 - Flags: approval1.8.1?

Updated

13 years ago
Attachment #226431 - Flags: approval1.8.1? → approval1.8.1+
Fix checked in to branch.
Keywords: fixed1.8.1
Priority: -- → P3
Target Milestone: --- → Firefox 2 beta1
Version: unspecified → Trunk
Component: Bookmarks → Microsummaries
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.