342233 - run TestGtkEmbed as part of unittests

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are a bunch of tests already in build-seamonkey-util.pl that use TestGtkEmbed.  We need to get a tinderbox running one of them (not codesize) that fails if it can't start up.

Having a usable embedding app is often critical for layout debugging; otherwise it's impossible to find what you want amid all the XUL stuff happening.

Lately TestGtkEmbed only seems to work about half the time, and that's not good enough.  (Or maybe I'm just forgetting the right GRE incantation needed to start it, which needs to be documented somewhere, but I really think GRE_HOME=. worked last week.)  The tree needs to be closed if it can't start up.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Well, I found a way to work around my problems:
./firefox -chrome data:text/html,<iframe width=300 height=300 src="http://www.webstandards.org/act/acid2/test.html#top"'

Comment 2

[Benjamin Smedberg]

GTKMozEmbed will only work "properly" in libxul builds, with GRE_HOME set. In non-libxul builds of Firefox you'll need to use run-mozilla.sh in addition. GtkMozEmbed is not even built in static Firefox builds.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I set GRE_HOME=. and used ./run-mozilla.sh and it crashed on startup.  Which is why I think we need a tinderbox.

Comment 4

[Robert Helmer [:rhelmer]]

Alice/Robcee - can this be handled by either the unit test framework or the new perf test framework? Please take this bug if so :)

Comment 5

[Rob Campbell [:rc] (:robcee)]

I think we could add it to the unit testing framework. I'll take a look.

Comment 6

[(not currently active) Ted Mielczarek]

TestGtkEmbed currently builds, right?

Comment 7

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

1) I've updated the summary, base on as best as I understand the discussion here. Let me know if I missed anything. 

2) Are these tests in build-seamonkey-util.pl done as a self-contained set,(and should be a new suite) or are they scattered, and should be added to an existing suite?

3) Per comment#3 these proposed tests were failing on startup. I assume these tests do pass now? 

4) Quick scan of mozilla-central by ctalbert finds many references. Are elements of this already in place? 
http://mxr.mozilla.org/mozilla-central/search?string=testgtkembed


Moving to future until we figure out what is to be done here.

Comment 8

[Chris Cooper [:coop] (he/him)]

Is this still necessary?

Comment 9

[Chris Cooper [:coop] (he/him)]

Moving closed Future bugs into Release Engineering in preparation for removing the Future component.