Closed Bug 342253 Opened 18 years ago Closed 18 years ago

Add RTL NSIS installer header image code

Categories

(Firefox :: Installer, defect)

Product:
Firefox
Component:
Installer
Version:
2.0 Branch
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

(Keywords: fixed1.8.1, rtl)

Attachments

(1 file)

patch
3.79 KB, patch
moco
: review+
darin.moz
: approval1.8.1+
Details | Diff | Splinter Review
I have a patch ready and working... just waiting on bug 340173 and bug 342251.
Flags: blocking-firefox2?
Whiteboard: [swag: 0d]
Attached patch patch — — Splinter Review
Attachment #226586 - Flags: review?(sspitzer)
Comment on attachment 226586 [details] [diff] [review] patch r=sspitzer or should I say: sspitzer=r
Attachment #226586 - Flags: review?(sspitzer) → review+
Fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [swag: 0d]
Attachment #226586 - Flags: approval1.8.1?
Attachment #226586 - Flags: approval1.8.1?
Comment on attachment 226586 [details] [diff] [review] patch We need this to properly display the header image for RTL languages in the installer. This depends on the images being checked in from bug 342251.
Attachment #226586 - Flags: approval1.8.1?
Comment on attachment 226586 [details] [diff] [review] patch a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to this bug)
Attachment #226586 - Flags: approval1.8.1? → approval1.8.1+
Checked in to MOZILLA_1_8_BRANCH for Firefox 2.0
Flags: blocking-firefox2?
Keywords: fixed1.8.1
Mass-assigning the new rtl keyword to RTL-related (see bug 349193).
Keywords: rtl
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: