342280 - hidesidebar cookie gets set to 0 (or is ignored) when loading another page in Gecko DOM reference

Status: RESOLVED WORKSFORME

(developer.mozilla.org Graveyard :: General, defect)

Description

[jsd]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060508 Firefox/1.5.0.4

Hi there. I have a problem with the hidesidebar cookie not working correctly in the Gecko DOM reference (and other references,) on the MDC site. The hidesidebar cookie is set to 1 when I hide the RHS sidebar. When I move around the Gecko DOM reference the hidesidebar cookie value appears to get reset to 0, and I have to hide the side-bar again every time I access another page of the DOM reference, which is a bit annoying and of a waste of time. Sometimes the hidesidebar cookie retains it's value of 1, (eg on the CSS reference) but the sidebar is still being displayed. This appears to be a sitewide problem. I'm not sure if it is the MDC sitecode, or a Firefox problem, as this seems to happen with Mozilla 1.7.12 as well. However, the hidetoc cookie is working just fine. Please can the hidesidebar cookie be made to work correctly like the hidetoc cookie?

Reproducible: Always

Steps to Reproduce:
1. Go to the Gecko CSS reference 'getting started' page at: 
   http://developer.mozilla.org/en/docs/CSS:Getting_Started

2. Click on 'hide' to hide the LHS Contents menu.

3. Click on 'Hide Sidebar' to hide the RHS sidebar menu.

4. Click on Edit->Preferences->Cookies->View Cookies

5. Find the 'hidesidebar' cookie under developer.mozilla.org and view it's   contents (which should be '1' which I take as a boolean value to hide the 
side-bar?).

6. Go down the page to the Tutorila Part 1 section, and click on link 2. Why use CSS.

7. When that page loads you will see the sidebar displayed again.

8. Now view the contents of the 'hidesidebar' cookie as described above. You will  see that the cookie value is still set to  '1', but the sidebar is not being hidden.

Obviously something is not quite right.

Actual Results:  
The sidebar is still being displayed across different pages of the MDC reference(s) when I have asked for it not to be.

Expected Results:  
The sidebar should stay hidden as I move around the pages of each reference, the same as the Contents menu on the LHS remains hidden.

Comment 1

[Philip Withnall (unavailable)]

Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9a1) Gecko/20060622 Minefield/3.0a1 - Build ID: 0000000000
Confirmed.

Comment 2

[Reed Loden [:reed]]

--> MDC

Comment 3

[Chad McHenry]

Attachment: Patch to remember sidebar visibility

Fixes the users issue: pages remember and respect hidesidebar cookie
Removes dead and or duplicate javascript code from earlier versions of same

Comment 4

[Mike Shaver (:shaver emeritus)]

Comment on attachment 235625 [details] [diff] [review]
Patch to remember sidebar visibility

r=shaver, looking for assent or test wishes from dria before landing.

Comment 5

[Deb Richardson [:dria] (plz NEEDINFO)]

As with most changes, I'd like this to be tested on developer-stage before pushing to live, but I'm not sure if developer-stage is in a state to allow that right now.  

Comment 6

[Mike Shaver (:shaver emeritus)]

This WFM, perhaps unsurprisingly.