nsIEffectiveTLDService needs tests added to netwerk/tests/unit/.
Here's a simple test I made: > var tldService = Components.classes["@mozilla.org/network/effective-tld-service;1"] > .getService(Components.interfaces.nsIEffectiveTLDService); > for each (var host in ["bugzilla.mozilla.org","theregister.co.uk","mysite.us","184.108.40.206"]) > dump(host + ": " + tldService.getEffectiveTLDLength(host) + "\n"); The examples are actually from nsIEffectiveTLDService.idl, only one is mine. Results: > bugzilla.mozilla.org: 3 > theregister.co.uk: 2 > mysite.us: 2 > 220.127.116.11: 3 Bugs filed: bug 364203, bug 364129
I read the docs, but not the code (my C++ isn't so great). But based on the comments in this bug, I wanted to inquire about two testcases: 1- The IP address test case (last in #1). Shouldn't this service never handle IP addresses? Or is it assumed that the callers will already distinguish IP addresses from FQDNs? 2- What about a literal FQDN, like "localhost." or "www.mozilla.org."
Argh nevermind. I just got done reading all my bugmail on this service... These questions are being addressed in other bugs. The long bug titles were truncated when I moused over references to other bugs.
Seems unlikely I'll get to this anytime soon.
Assignee: pamg.bugs → nobody
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.