Closed Bug 342329 Opened 18 years ago Closed 15 years ago

Install updates should be disabled if all add-ons have been deselected for update.

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: robert.strong.bugs, Assigned: lusian)

References

Details

Attachments

(1 file, 1 obsolete file)

Disable the "Install Updates" button if all add-ons are deselected for update, 1
3.29 KB, patch
mossop
: review+
Details | Diff | Splinter Review 
spinoff from bug 307358. Another option may be to just use the add-ons message notification area - this would be *much* simpler and cleaner.
Product: Firefox → Toolkit
Whiteboard: [good first bug]
Attachment #405821 - Flags: review?(robert.bugzilla)
Attachment #405821 - Flags: review?(robert.bugzilla) → review?(dtownsend)
Comment on attachment 405821 [details] [diff] [review]
Disable the "Install Updates" button if all add-ons are deselected for update, 0

You shouldn't need to loop through the entire list most of the time. As soon as you find a single checked checkbox you can enable the button at that point and end the loop.
Attachment #405821 - Flags: review?(dtownsend) → review-

        Attachment #405821 -
        Attachment is obsolete: true

        Attachment #405960 -
        Flags: review?(dtownsend)

        Attachment #405960 -
        Flags: review?(dtownsend) → review+

    
  

        Attachment #405960 -
        Flags: ui-review?(beltzner)

    
    

    
  
Comment on attachment 405960 [details] [diff] [review]
 Disable the "Install Updates" button if all add-ons are deselected for update, 1

This does not need a ui review

        Attachment #405960 -
        Flags: ui-review?(beltzner)

    
    

    
  
Somebody push the patch to the trunk, please?

    
    

    
  
Pushed to trunk: http://hg.mozilla.org/mozilla-central/rev/8e1ea35b1294
Assignee: nobody → lusian
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → mozilla1.9.3a1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: