342377 - Add do_ensure to the test harness

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I find myself writing 

  do_check_eq(... , true);

a whole lot.  do_ensure would just save some typing.  ;)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

Comment 2

[Dave Liebreich [:davel]]

I'm leaning towards standardizing on *unit-named tests, like assertTrue, assertEquals, ...

Also, I'm not sure how long-lived this set of methods will be, since it may be easier to port tests to a slightly different harness (still based on xpcshell, but more like jsunit) than to try to add the reporting and invocation infrastructure to this set of code.

As a short-term comprimise, would you be willing to rename do_ensure() to do_check_true()?

-Dave, who with this comment just wiped out the amount of typing saved in test cases

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: With do_check_true

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in.  Thanks!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Er, actually checked in now for real.