342392 - editable menulist slightly different in size from other widgets

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

The editable menulist microsummary picker in the Add Bookmarks and Bookmark Properties dialog boxes is slightly different in size from the other textboxes and menulists in the dialog, making it look off.  This seems to be related to how much margin the widget gets relative to the other widgets in the dialogs.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot demonstrating problem

Here's a screenshot showing the problem.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: make gnomestripe menulist margin consistent with other widgets/platforms

The problem is that menulists in gnomestripe have only 2px left and right margin.  They have 4px margin in winstripe and pinstripe, as do other widgets likely to be aligned alongside them (textboxes, checkboxes, radio buttons).

Seems like menulists on Linux should be consistent with other widgets and other platforms.  Here's the trivial patch that makes that happen.  I've checked other uses of menulists in Firefox (mostly in the Preferences pane), and they all look fine with the patch applied.  Seems like we should take this on the branch, since the bug makes all bookmark dialogs look a bit off on Linux, and the risk is low, so requesting approval.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 236169 [details] [diff] [review]
patch v1: make gnomestripe menulist margin consistent with other widgets/platforms

a=beltzner on behalf of 181drivers

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Fix checked in to trunk and branch.