342432 - After Undo Close Tab, content area of newly-opened page isn't focused

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060622 Minefield/3.0a1

Steps to reproduce:
1. Open a new tab and close it.
2. Right click on a tab and choose Undo Close Tab.

Results:
Tab clicked on remains focused with dotted outline showing.

Expected results:
Newly-opened tab's content area needs to be focused.

Comment 1

[Dietrich Ayala (:dietrich)]

This is an addition to the main undo-close-tab feature. Shouldn't block bug 342179, which is unrelated AFAICT.

Comment 2

[Dietrich Ayala (:dietrich)]

Re: bug 343803 comment #4, the fix for this bug should also address which tab gets focus when re-opening multiple closed tabs via the history menu.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

I'm guessing that Dietrich meant to take this when he marked it as assigned... :)

Comment 4

[Simon Bünzli]

Adam: can you still reproduce this issue?

Comment 5

[Adam Guthrie]

Yep. I can reproduce on current trunk and branch. 

This only happens if you use Undo Close Tab from the tab context menu; the page is focused correctly if you open the tab from the History > Recently Closed Tabs menu.

Comment 6

[Simon Bünzli]

Right, this still happens if you right-click on the _current_ tab (which gets the focus with the click and won't let it go).

I'm not sure whether the correct solution should rather be to just move the focus rectangle to the reopened tab though. Or maybe - for accessibility reasons - we're not supposed to move the focus at all.

Aaron: what would the correct behavior be in this case?

Comment 7

[Aaron Leventhal]

The right thing to do would be to focus the new tab's contents.

Comment 8

[Simon Bünzli]

Attachment: always focus the reopened tab's content area

Like this?

Comment 9

[Aaron Leventhal]

Comment on attachment 236968 [details] [diff] [review]
always focus the reopened tab's content area

I can't do superreviews and anyway you don't need them for chrome. You need a toolkit/browser peer to review this (and I'm not one, I don't think dietrich is either). Try bugs.mano or someone listed on mozilla.org.

Comment 10

[Simon Bünzli]

Comment on attachment 236968 [details] [diff] [review]
always focus the reopened tab's content area

(In reply to comment #9)
> I can't do superreviews and anyway you don't need them for chrome.

I know, I know. OTOH you're the accessibility guru and I'd like to know whether the solution chosen is acceptable from your point of view (and "superreview" is the closest to an "access-review" flag we have).

Comment 11

[Asaf Romano (gone)]

Comment on attachment 236968 [details] [diff] [review]
always focus the reopened tab's content area

r=mano

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/sessionstore/src/nsSessionStore.js 	1.49