342458 - Warnings when opening bookmarks sidebar

Status: VERIFIED FIXED

(Firefox Graveyard :: Microsummaries, defect)

Description

[Simon Bünzli]

Warning: assignment to undeclared variable MICSUMSVC
Source file: chrome://browser/content/bookmarks/bookmarks.js
Line: 99
 ----------
Warning: assignment to undeclared variable kMICSUMIID
Source file: chrome://browser/content/bookmarks/bookmarks.js
Line: 98
 ----------
Warning: assignment to undeclared variable kMICSUMContractID
Source file: chrome://browser/content/bookmarks/bookmarks.js
Line: 97

Comment 1

[Simon Bünzli]

Attachment: fix

Note that although this is a trunk patch, AFAICT you won't notice this issue unless you disable Places.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 226704 [details] [diff] [review]
fix

Good catch.  Indeed, this will only show up on a non-Places build, but there are folks still making such builds on the trunk, and we should keep the code there in good working order until Places replaces it for good.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Fix checked in on trunk.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 226704 [details] [diff] [review]
fix

Notes for drivers considering the approval1.8.1 request:

This patch has just landed on the trunk, but letting it bake for a couple days won't help test it, because it's specific to the old bookmarks code, which is disabled on the trunk.

There's virtually no risk of regression from this patch.  It's a simple variable declaration to get rid of a "variable used without being defined" warning.

Comment 5

[Darin Fisher]

Comment on attachment 226704 [details] [diff] [review]
fix

a=darin on behalf of drivers (please land this on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to this bug)

Comment 6

[Simon Bünzli]

Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2 ID:2006082803.