Closed
Bug 342491
Opened 18 years ago
Closed 16 years ago
Assertion Failed (ASSERT: null node) right-click "cut/copy" on bookmarks toolbar
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: bugmozz, Assigned: christineyen+bugs)
References
Details
Attachments
(1 file)
67.61 KB,
image/jpeg
|
Details |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060622 Minefield/3.0a1 ID:2006062204 [cairo] screen shot : http://img155.imageshack.us/img155/2388/aaa2is.jpg
Updated•18 years ago
|
Component: Bookmarks → Places
QA Contact: bookmarks → places
Comment 1•18 years ago
|
||
Because text is so much easier to search: ASSERT: null node Stack Trace: 0:PC_nodeIsFolder(null) 1:PC_wrapNode([xpconnect wrapped (nsISupports, nsINavHistoryQueryResultNode, nsINavHistoryFolderResultNode, nsINavHistoryContainerResultNode)], text/x-moz-place-container) 2:generateChunk(text/x-moz-place-container) 3:() 4:oncommand([object XULCommandEvent])
Comment 2•18 years ago
|
||
WFM (no error) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060622 Minefield/3.0a1 and it even cuts/copies :)
(In reply to comment #2) > WFM (no error) with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) > Gecko/20060622 Minefield/3.0a1 and it even cuts/copies :) > not on bookmark title but on SPACES in bookmarks toolbar.
I get assertion too when cutting/deleting bookmarks but I can't reproduce it always.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a5pre) Gecko/20070512 Minefield/3.0a5pre ID:2007051204 [cairo][Places-Bookmarks] right-click on spaces in bookmarks toolbar, and select "copy" [screen shot] http://img156.imageshack.us/img156/6459/fffay1.jpg
Assignee | ||
Comment 6•17 years ago
|
||
Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a7pre) Gecko/2007070504 Minefield/3.0a7pre Verified on OS X. When right-clicking on a blank space in the bookmarks toolbar, cut is disabled but copy is enabled. Clicking copy results in an ASSERT: null node as described in the description.
Assignee: nobody → cyen
OS: Windows XP → All
Hardware: PC → All
Assignee | ||
Comment 7•17 years ago
|
||
Asserts because wrapNode() in utils.js is running nodeIsFolder on a potentially null value (aNode.parent). http://mxr.mozilla.org/seamonkey/source/browser/components/places/content/utils.js#476 The same problem arises when copying the "Bookmarks" folder in the left pane of the Bookmark Manager, which also doesn't have a parent. Fixed (in a sense) by the patch for bug 378558, but in this case, selecting "copy" on the blank area of the bookmarks toolbar ends up copying the entire bookmark toolbar folder to the clipboard, which may or may not be a bug. On the other hand, for comparison, Firefox 2 simply doesn't allow "copy" when right clicking on the blank area of the toolbar.
Status: NEW → ASSIGNED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a8pre) Gecko/2007091816 Minefield/3.0a8pre ID:2007091816 cannot reproduce now, so should be marked as/changed to "WFM" or something ?
Comment 9•16 years ago
|
||
copy is no longer enabled -> WFM
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 10•16 years ago
|
||
(In reply to comment #9) > copy is no longer enabled -> WFM > Thanks. but it's enabled. see screenshot.
Comment 11•16 years ago
|
||
hm, it's not enabled on Mac. can you reproduce the error when selecting it?
Reporter | ||
Comment 12•16 years ago
|
||
(In reply to comment #11) > hm, it's not enabled on Mac. can you reproduce the error when selecting it? > No error now. see comment#8
Comment 13•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•