Closed Bug 342592 Opened 14 years ago Closed 12 years ago

Make --enable-extensions=inspector work for XULRunner

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9beta1

People

(Reporter: WeirdAl, Assigned: WeirdAl)

References

Details

Attachments

(1 file)

With DOM Inspector enabled through MOZCONFIG, DOM-I installs itself (somewhat uselessly) in dist\bin\extensions\inspector@mozilla.org .  As a result, its chrome packages (chrome://inspector/content, for example) don't get recognized.  Similarly, the defaults/preferences and components directories are under dist/bin/extensions and are not recognized.

I suppose in theory bin/extensions/foo/* should work as if it were in bin/*.  bsmedberg, any ideas why it wouldn't?
We've been building with --enable-extensions=inspector for some time now. All we had to do was make sure and update the install.rdf file with our app uuid and version numbers. Chrome addresses, command line handler, prefs all work as expected.
Ref bug 299716 for a better solution than I had in mind.
Re comment 1: It works as described, if I also apply the line:

overlay chrome://foo/content/foo.xul chrome://inspector/content/tasksOverlay.xul

to bin/inspector@extensions.bugs/chrome/chrome.manifest .  Applying said line to my own app's chrome.manifest caused bustage.

Still, the idea of hacking inspector@extensions.bugs/install.rdf to support my application is unappetizing...
(In reply to comment #3)
> Still, the idea of hacking inspector@extensions.bugs/install.rdf to support my
> application is unappetizing...

The only way around that is to take venkman's approach (install inspector as chrome, not an extension) or to fix bug 299716.
Attached patch patch, v1Splinter Review
I'm not sure about the MIN_VERSION value here (cc'ing Robert for his opinion on that).

Also, I haven't yet been able to successfully test this.  (XR on Linux build failed to compile.)
Attachment #278771 - Flags: review?
Attachment #278771 - Flags: review? → review?(comrade693+bmo)
Comment on attachment 278771 [details] [diff] [review]
patch, v1

minversion should be a1 since that is the last binary change that we had.

Otherwise, r=sdwilsh.

This needs sr (and you might want to move this to other apps->DOMi)
Attachment #278771 - Flags: review?(comrade693+bmo) → review+
Status: NEW → ASSIGNED
Component: XULRunner → DOM Inspector
Product: Toolkit → Other Applications
Target Milestone: --- → mozilla1.9beta
Comment on attachment 278771 [details] [diff] [review]
patch, v1

per sdwilsh's request
Attachment #278771 - Flags: superreview?(neil)
Attachment #278771 - Flags: superreview?(neil)
Attachment #278771 - Flags: superreview?(neil)
Attachment #278771 - Flags: superreview?(neil) → superreview+
Whiteboard: [checkin needed]
Keywords: checkin-needed
Whiteboard: [checkin needed]
Fixed review nit before checking in.

Checking in extensions/inspector/install.rdf;
new revision: 1.15; previous revision: 1.14
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Version: unspecified → Trunk
Blocks: 496681
No longer blocks: 496681
You need to log in before you can comment on or make changes to this bug.