If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[BeOS] Tools - Options - General buttons are non-functional on BeOS trunk builds

RESOLVED WONTFIX

Status

()

Firefox
Preferences
RESOLVED WONTFIX
11 years ago
11 years ago

People

(Reporter: Doug Shelton, Unassigned)

Tracking

({regression})

2.0 Branch
x86
BeOS
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060618 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060618 Minefield/3.0a1

Buttons on General panel are non-functional (Use Current Page, Use Bookmark, Use Blank Page; Connection Settings...; Choose Feed Reader.  Not sure exactly when this broke but maybe around the time the feed reader option was added.  If a URL is typed into the Home Page form and "enter" is pressed, the setting takes effect, so at least something on the panel works.  All other preference panels/tabs work fine.

Reproducible: Always
(Reporter)

Updated

11 years ago
Blocks: 311032
(Reporter)

Updated

11 years ago
Status: NEW → ASSIGNED

Comment 1

11 years ago
tigerdog, do you see this problem in Minefield Nighties for Windows?
(Reporter)

Comment 2

11 years ago
works OK in Minefield nightly for Windows 2006-06-25
(Reporter)

Comment 3

11 years ago
It seems this problem surfaced about the same time bug 333751 was committed.  the BeOS team were not completing nightly builds at the time so we can't pinpoint the exact date, but the problem can be seen in builds going back to 2006-05-12.  Could be a regression?
(Reporter)

Comment 4

11 years ago
This is a regression caused by commits from bug 333571.  --disable-feeds restores old panel and all buttons work.
Summary: Tools - Options - General buttons are non-functional on BeOS trunk builds → [BeOS] Tools - Options - General buttons are non-functional on BeOS trunk builds
(Reporter)

Updated

11 years ago
Depends on: 333571
(Reporter)

Comment 5

11 years ago
Changing from preferences to build config.  It appears BeOS does not pull/build all files necessary for feed.  Pulled clean trunk but browser/components/feeds are not present, nor does make -f try to build them.
Component: Preferences → Build Config
(In reply to comment #3)
> It seems this problem surfaced about the same time bug 333751 was committed. 

(In reply to comment #4)
> This is a regression caused by commits from bug 333571.  --disable-feeds
> restores old panel and all buttons work.

I think you got the bug number wrong in your comment #4, as bug 333571 doesn't have anything to do with this whereas bug 333751 does. Therefore I'll correct, apologies if I am wrong.
Depends on: 333751
No longer depends on: 333571
QA Contact: preferences → build.config
(Reporter)

Comment 7

11 years ago
(In reply to comment #6)
> (In reply to comment #3)
> > It seems this problem surfaced about the same time bug 333751 was committed. 
> 
> (In reply to comment #4)
> > This is a regression caused by commits from bug 333571.  --disable-feeds
> > restores old panel and all buttons work.
> 
> I think you got the bug number wrong in your comment #4, as bug 333571 doesn't
> have anything to do with this whereas bug 333751 does. Therefore I'll correct,
> apologies if I am wrong.
> 

You are correct.  Thank you for catching my unintended transposition.  
(Reporter)

Comment 8

11 years ago
Created attachment 227255 [details]
mozconfig in use while experiencing this problem

odd comment format makes them stand out in BeOS IDE.
Blocks: 333751
No longer depends on: 333751
Flags: blocking1.9a2?
Flags: blocking-firefox2?
Keywords: regression
(Reporter)

Comment 9

11 years ago
problem goes away if mozilla/browser/components/preferences/general.js is backed out to version 1.7.
(Reporter)

Comment 10

11 years ago
changing component back to preferences; seems all files are being pulled/built after all.
Component: Build Config → Preferences
QA Contact: build.config → preferences
(Reporter)

Comment 11

11 years ago
Created attachment 227324 [details] [diff] [review]
fixes problem

Depending on platform and conditionals, preprocessor sometimes inserts extraneous comma in output.  This fixes it.
Attachment #227255 - Attachment is obsolete: true
(Reporter)

Updated

11 years ago
Attachment #227324 - Flags: review?(vladimir)
This code is all going away in its present form in bug 340677, so this bug is not going to be useful, unfortunately.  :-\  I'm writing the patch for that bug, so when I post a reviewable patch, feel free to give it a test to make sure this bug isn't present.  I'll be specifically watching out for this problem, so hopefully it won't be present.
Depends on: 340677
(Reporter)

Comment 13

11 years ago
(In reply to comment #12)
> This code is all going away in its present form in bug 340677, so this bug is
> not going to be useful, unfortunately.  :-\  I'm writing the patch for that
> bug, so when I post a reviewable patch, feel free to give it a test to make
> sure this bug isn't present.  I'll be specifically watching out for this
> problem, so hopefully it won't be present.
> 
Thanks for the heads-up; I'll watch 340677.

Comment 14

11 years ago
Clearing blocking flag given comment #12
Flags: blocking-firefox2?
(Reporter)

Comment 15

11 years ago
Comment on attachment 227324 [details] [diff] [review]
fixes problem

still awaiting review.
Attachment #227324 - Flags: review?(vladimir) → review?(mconnor)
(Reporter)

Comment 16

11 years ago
mconnor, please ignore review request.  based on progress of bug 340667, marking this "WONTFIX" and will test new code to insure problem does not occur in the next iteration of the Prefs panel.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WONTFIX
(Reporter)

Updated

11 years ago
Attachment #227324 - Flags: review?(mconnor)
(Reporter)

Comment 17

11 years ago
This problem still exists in latest branch build.  If the updated prefs are being dropped from 2.0, I believe we need to commit this fix on the branch.
Severity: major → normal
Version: unspecified → 2.0 Branch
(Reporter)

Updated

11 years ago
Attachment #227324 - Flags: review?(jwalden+bmo)
Attachment #227324 - Flags: approval1.8.1?

Comment 18

11 years ago
Comment on attachment 227324 [details] [diff] [review]
fixes problem

Jeff can you clarify whether this is still needed now that the need prefs/feed UI is in?
Attachment #227324 - Flags: approval1.8.1?
(In reply to comment #18)
> (From update of attachment 227324 [details] [diff] [review] [edit])
> Jeff can you clarify whether this is still needed now that the need prefs/feed
> UI is in?

No, it's not needed.
Attachment #227324 - Flags: review?(jwalden+bmo)
Flags: blocking1.9a2?
You need to log in before you can comment on or make changes to this bug.