342639 - [BeOS] Tools - Options - General buttons are non-functional on BeOS trunk builds

Status: RESOLVED WONTFIX

(Firefox :: Settings UI, defect)

Description

[Doug Shelton]

User-Agent:       Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060618 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (BeOS; U; BeOS BePC; en-US; rv:1.9a1) Gecko/20060618 Minefield/3.0a1

Buttons on General panel are non-functional (Use Current Page, Use Bookmark, Use Blank Page; Connection Settings...; Choose Feed Reader.  Not sure exactly when this broke but maybe around the time the feed reader option was added.  If a URL is typed into the Home Page form and "enter" is pressed, the setting takes effect, so at least something on the panel works.  All other preference panels/tabs work fine.

Reproducible: Always

Comment 1

[Sergei Dolgov]

tigerdog, do you see this problem in Minefield Nighties for Windows?

Comment 2

[Doug Shelton]

works OK in Minefield nightly for Windows 2006-06-25

Comment 3

[Doug Shelton]

It seems this problem surfaced about the same time bug 333751 was committed.  the BeOS team were not completing nightly builds at the time so we can't pinpoint the exact date, but the problem can be seen in builds going back to 2006-05-12.  Could be a regression?

Comment 4

[Doug Shelton]

This is a regression caused by commits from bug 333571.  --disable-feeds restores old panel and all buttons work.

Comment 5

[Doug Shelton]

Changing from preferences to build config.  It appears BeOS does not pull/build all files necessary for feed.  Pulled clean trunk but browser/components/feeds are not present, nor does make -f try to build them.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #3)
> It seems this problem surfaced about the same time bug 333751 was committed. 

(In reply to comment #4)
> This is a regression caused by commits from bug 333571.  --disable-feeds
> restores old panel and all buttons work.

I think you got the bug number wrong in your comment #4, as bug 333571 doesn't have anything to do with this whereas bug 333751 does. Therefore I'll correct, apologies if I am wrong.

Comment 7

[Doug Shelton]

(In reply to comment #6)
> (In reply to comment #3)
> > It seems this problem surfaced about the same time bug 333751 was committed. 
> 
> (In reply to comment #4)
> > This is a regression caused by commits from bug 333571.  --disable-feeds
> > restores old panel and all buttons work.
> 
> I think you got the bug number wrong in your comment #4, as bug 333571 doesn't
> have anything to do with this whereas bug 333751 does. Therefore I'll correct,
> apologies if I am wrong.
> 

You are correct.  Thank you for catching my unintended transposition.  

Comment 8

[Doug Shelton]

Attachment: mozconfig in use while experiencing this problem

odd comment format makes them stand out in BeOS IDE.

Comment 9

[Doug Shelton]

problem goes away if mozilla/browser/components/preferences/general.js is backed out to version 1.7.

Comment 10

[Doug Shelton]

changing component back to preferences; seems all files are being pulled/built after all.

Comment 11

[Doug Shelton]

Attachment: fixes problem

Depending on platform and conditionals, preprocessor sometimes inserts extraneous comma in output.  This fixes it.

Comment 12

[Jeff Walden [:Waldo]]

This code is all going away in its present form in bug 340677, so this bug is not going to be useful, unfortunately.  :-\  I'm writing the patch for that bug, so when I post a reviewable patch, feel free to give it a test to make sure this bug isn't present.  I'll be specifically watching out for this problem, so hopefully it won't be present.

Comment 13

[Doug Shelton]

(In reply to comment #12)
> This code is all going away in its present form in bug 340677, so this bug is
> not going to be useful, unfortunately.  :-\  I'm writing the patch for that
> bug, so when I post a reviewable patch, feel free to give it a test to make
> sure this bug isn't present.  I'll be specifically watching out for this
> problem, so hopefully it won't be present.
> 
Thanks for the heads-up; I'll watch 340677.

Comment 14

[Mike Schroepfer]

Clearing blocking flag given comment #12

Comment 15

[Doug Shelton]

Comment on attachment 227324 [details] [diff] [review]
fixes problem

still awaiting review.

Comment 16

[Doug Shelton]

mconnor, please ignore review request.  based on progress of bug 340667, marking this "WONTFIX" and will test new code to insure problem does not occur in the next iteration of the Prefs panel.

Comment 17

[Doug Shelton]

This problem still exists in latest branch build.  If the updated prefs are being dropped from 2.0, I believe we need to commit this fix on the branch.

Comment 18

[Mike Schroepfer]

Comment on attachment 227324 [details] [diff] [review]
fixes problem

Jeff can you clarify whether this is still needed now that the need prefs/feed UI is in?

Comment 19

[Jeff Walden [:Waldo]]

(In reply to comment #18)
> (From update of attachment 227324 [details] [diff] [review] [edit])
> Jeff can you clarify whether this is still needed now that the need prefs/feed
> UI is in?

No, it's not needed.