342642 - Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame ::

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Bryan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060624 BonEcho/2.0a3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060624 BonEcho/2.0a3

Under specific conditions an exception is generated in the Error Console when "Clear Private Data" is used:

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: observe :: line 637" data: no]
Source File: chrome://global/content/bindings/browser.xml
Line: 637

Reproducible: Always

Steps to Reproduce:
1) Set about:config javascript.options.showInConsole = true
2) Open two tabs and load two sites, one in each tab. Allow each tab to completely load it's content
3) Launch Error Console and "clear" all events, minimize the Error Console
4) Select the second tab and click a link in that tab that will load a new page in that tab
5) Clear Private Data (CPD should be configured to clear at least browsing history)
6) You should observe the following error in the Error Console: 

Actual Results:  
An exception is generated in the Error Console when "Clear Private Data" is used:

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsISHistory.PurgeHistory]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: observe :: line 637" data: no]
Source File: chrome://global/content/bindings/browser.xml
Line: 637

Expected Results:  
No exception generated in the Error Console when using "Clear Private Data".

Comment 1

[Mike Connor [:mconnor]]

Not a blocker, what is happening is that the call at http://lxr.mozilla.org/mozilla/source/toolkit/content/widgets/browser.xml#662 is failing because there isn't any session history to purge in the first tab, but its not a harmful exception because of how it gets invoked.  Everything that should be cleared gets cleared.  We should still check for purge > 0 at the call linked above.

Comment 2

[Ria Klaassen (not reading all bugmail)]

Do you have an extension installed that deletes history per item?

Comment 3

[Ria Klaassen (not reading all bugmail)]

I once had such an extension (don't know its name anymore) and every time when I clicked "Remove this item from history" a new similar error was added to the console (but the exension seems to work). I stopped using it because it deleted also the whole session history under that tab (Back stopped working).

Comment 4

[Ria Klaassen (not reading all bugmail)]

Excuse; didn't read the steps to reproduce well because I suddenly recognized the well-known error in the summary. But I assume it is the same issue.

Comment 5

[Bryan]

(In reply to comment #2)
> Do you have an extension installed that deletes history per item?
> 

I experience the same issue during safe mode following the steps to reproduce above.

~B

Comment 6

[Simon Bünzli]

Attachment: trivial fix

Comment 7

[Asaf Romano (gone)]

Comment on attachment 230635 [details] [diff] [review]
trivial fix

r=mano

Comment 8

[Bryan]

Don't care about this anymore.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/browser.xml 	1.92

Comment 10

[Simon Bünzli]

Comment on attachment 230635 [details] [diff] [review]
trivial fix

Drivers: This one-line patch prevents an exception by checking whether there are history entries to be purged before actually doing so. Risk: very low.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230635 [details] [diff] [review]
trivial fix

a=drivers, please checkin on the 181 branch.

Comment 12

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/widgets/browser.xml 	1.70.2.15

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

*** Bug 296694 has been marked as a duplicate of this bug. ***