Closed Bug 342645 Opened 18 years ago Closed 18 years ago

Search bar shortcuts for opening the popup (Alt+Up/Down, F4) no longer work

Categories

(Firefox :: Search, defect)

2.0 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2 beta1

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

(Keywords: fixed1.8.1, Whiteboard: 181b1+)

Attachments

(1 file)

There was a small mistake in the fix for bug 340122 that made the shortcuts not work. Patch in a sec.
No longer blocks: 340122
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #226938 - Flags: review?(mconnor)
Flags: blocking-firefox2?
Whiteboard: [patch-r?]
Target Milestone: --- → Firefox 2 beta1
Yeesh.  Is there a litmus test that hits these?
Flags: blocking-firefox2? → blocking-firefox2+
Whiteboard: [patch-r?] → [patch-r?] 181b1+
Attachment #226938 - Flags: review?(mconnor) → review+
mozilla/browser/components/search/content/search.xml 	1.75
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r?] 181b1+ → 181b1+
Comment on attachment 226938 [details] [diff] [review]
patch

This is a trivial fix that is obviously correct, I don't think it would benefit from trunk baking.
Attachment #226938 - Flags: approval1.8.1?
Whiteboard: 181b1+ → [a?] 181b1+
Attachment #226938 - Flags: approval1.8.1? → approval1.8.1+
mozilla/browser/components/search/content/search.xml 	1.37.2.42
Keywords: fixed1.8.1
Whiteboard: [a?] 181b1+ → 181b1+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: