342708 - Unable to Remove Tags for IMAP Messages

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

This may only be a problem for messages with only a single tag. I think it's IMAP only.

when I remove the tag, the message looks like the tag has been removed (i.e. the color in the thread pane goes away, the tag column loses the tag value), but the next time the msgview repaints the row, the tag comes back. 

I wonder if the keyword on the server is not getting cleared.

Comment 1

[Scott MacGregor]

we'd probably hold alpha for this I think.

Comment 2

[David :Bienvenu]

yes, I think that's what's going on. There's an other bug open about that, I believe.

Comment 3

[David :Bienvenu]

Attachment: proposed fix

d'uh, go through the folder to remove the label, where we polymorphically do the right thing for imap.

Comment 4

[Scott MacGregor]

Comment on attachment 227112 [details] [diff] [review]
proposed fix

excellent.

Comment 5

[Scott MacGregor]

*** Bug 342902 has been marked as a duplicate of this bug. ***

Comment 6

[Scott MacGregor]

Hey David,

This checkin isn't showing up on bonsai for the 1.8.1 branch. Are you sure it went in there? :)

Comment 7

[David :Bienvenu]

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/mailnews/base/util&command=DIFF_FRAMESET&file=nsMsgDBFolder.cpp&rev1=1.257.2.7&rev2=1.257.2.8&root=/cvsroot

bonsai queries are showing the checkin for me...

Comment 8

[Scott MacGregor]

Oh, ignore my earlier question.

This still doesn't work for me in today's 06/27 branch build then. I thought it went in this morning but I see it went into the branch and trunk yesterday. 

Comment 9

[Brett Leber]

I reported this on 1.8 branch (2.0alpha1). This is on IMAP. (I could get more details on the server, if requested.) Whereas this report describes the tag as disappearing until a refresh of the thread pane, my experience is that the the message /flashes/--it loses the tag, loses the background color--but then instantly returns to the state where the tag is still applied, including the color. Subsequent tags can be applied and removed successfully, but the first one applied is locked.

Comment 10

[David :Bienvenu]

I've figured out what's going on here - we're not parsing the url to remove custom keywords correctly, so we're not removing the tags from the server. I'll code up a fix.

Comment 11

[David :Bienvenu]

Attachment: proposed fix

wanna try this out, Scott?

Comment 12

[David :Bienvenu]

fixed on trunk and branch

Comment 13

[Alex Ihrig [:Thunderbird_Mail_DE]]

Now it's possible to remove all tags from IMAP messages in all my IMAP accounts. But now there is an JS error, when selecting a message from my Hosteurope IMAP accounts (only in these accounts) and the tags are not allways shown/listed in the message header:

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgTagService.getKeyForTag]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://messenger/content/mailWidgets.xml :: buildTags :: line 993"  data: no]
Source File: chrome://messenger/content/mailWidgets.xml
Line: 993

Comment 14

[Alex Ihrig [:Thunderbird_Mail_DE]]

Ups, the problem could be related to the different Thunderbird locales. My profile was created using a german Thunderbird, so the standard labels (now tags) have german names. Now I'm running todays en-US Thunderbird with my german profile. So the defined tags in prefs.js may have german pref-names and differ from what the en-US Thunderbird wants to use?

Comment 15

[Alex Ihrig [:Thunderbird_Mail_DE]]

Creating a new en-US profile seems to work properly. So there must be a problem with the german standard tags - maybe a problem in encoding?

Here the lines out of my prefs.js:
-----
user_pref("mailnews.tags.$label1.color", "#FF0000");
user_pref("mailnews.tags.$label1.tag", "Wichtig");
user_pref("mailnews.tags.$label2.color", "#FF9900");
user_pref("mailnews.tags.$label2.tag", "Dienstlich");
user_pref("mailnews.tags.$label3.color", "#009900");
user_pref("mailnews.tags.$label3.tag", "Persönlich");
user_pref("mailnews.tags.$label4.color", "#3333FF");
user_pref("mailnews.tags.$label4.tag", "Zu erledigen");
user_pref("mailnews.tags.$label5.color", "#993399");
user_pref("mailnews.tags.$label5.tag", "Später");
user_pref("mailnews.tags.Gelb.color", "#FFFF00");
user_pref("mailnews.tags.Gelb.tag", "Gelb");
user_pref("mailnews.tags.Umlaut_Test_mit_&AOQA,AD8-_und_&IKw-_Euro.color", "");
user_pref("mailnews.tags.Umlaut_Test_mit_&AOQA,AD8-_und_&IKw-_Euro.tag", "Umlaut Test mit äüü und € Euro");
user_pref("mailnews.tags.version", 1);
-----

The standard tags are UTF-8 encoded, the individual created tags ("Gelb" and "Umlaut Test mit ......" have an other encoding. Could the UTF-8 encoding be the problem?

Comment 16

[Alex Ihrig [:Thunderbird_Mail_DE]]

Thinking about this, the encoding can't be the problem. ALL standard tags have the JS error (independed from using encoded letters or not - e.g. "Dienstlich" and "Später"). Only the individual created tags (both with and without encoded letters) are working properly in the en-US Thunderbird.

In 2-3 hours todays german Thunderbird build will be created and I'm able to test my german profile with the german Thunderbird.

Comment 17

[Alex Ihrig [:Thunderbird_Mail_DE]]

Yes, there must be a problem with the 2 locales:

The "Tags" column shows both words (the german AND the english). E.g.: "SpäterLater" or "WichtigImportant".

Comment 18

[Alex Ihrig [:Thunderbird_Mail_DE]]

Sorry for spamming here, but it's so suspicious...

Now, after switching to another folder and switching back to the previous folder, Thunderbird shows only the english tags in the "Tags" column. In the first moment after tagging a message it shows both words/languages until I switch the folder.

Comment 19

[Brett Leber]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629 Thunderbird/2.0a1 ID:2006062906

It looks like I can now remove tags, but when I apply one of the original labels (Important, for example) as a tag, it shows up twice in the message header in the message preview pane.

Comment 20

[Scott MacGregor]

(In reply to comment #19)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629
> Thunderbird/2.0a1 ID:2006062906
> 
> It looks like I can now remove tags, but when I apply one of the original
> labels (Important, for example) as a tag, it shows up twice in the message
> header in the message preview pane.
> 

File a new bug on me for that. Thanks!

Comment 21

[Alex Ihrig [:Thunderbird_Mail_DE]]

(In reply to comment #19)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060629
> Thunderbird/2.0a1 ID:2006062906
> 
> It looks like I can now remove tags, but when I apply one of the original
> labels (Important, for example) as a tag, it shows up twice in the message
> header in the message preview pane.
> 

This is/could be related to my problems. Using the en-US only Tb/profile, I can see the english tag 2 times (e.g. "LaterLater"). Using the en-US Tb with german profile I can see the combination of both the german and english tags (SpäterLater).

Comment 22

[Alex Ihrig [:Thunderbird_Mail_DE]]

Filed bug 343170

Comment 23

[Alex Ihrig [:Thunderbird_Mail_DE]]

Filed bug 343179 - JS error by message tags, if using a Thunderbird locale in combination with a profile created with an other locale

Comment 24

[Alex Ihrig [:Thunderbird_Mail_DE]]

We can re-close this bug again.

Comment 25

[Scott MacGregor]

cool.

Comment 26

[Travis Saling]

I think this bug needs to be reopened. Things appear to be somewhat broken again on the last several 1.8 (2.0a1) nightlies, at least in IMAP. I'm using it on OS X.

Steps to reproduce:

1) Tag a message in your Inbox as "Important" - actually any tag that has an associated color should work.
2) Right-click and select "Remove all tags" for the message.
3) Observe that the tag appears to have been removed, and the color is gone.
4) Click around a bit, or else just go view a different IMAP folder and then come back to Inbox.
5) The message will have regained the color from the tag applied in step 1. If you right-click on the message, it will show the tag checked once again. The tag will not be listed in the message header display though.

Comment 27

[Brett Leber]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1) Gecko/20061102 Thunderbird/2.0b1pre ID:2006110203

Tags are still not removing properly for me. It's still possible for me to produce duplicate tags on a message. This is observable on two different IMAP accounts.

I add a tag. Then I click to remove a tag (either using the keyboard access key or the tag sub-menu) and the tag appears to be removed. I navigate off the message and back on to it. The preview pane shows no tags in the header, but the tag color reappears on the message; the tag(s) reappear in the 'Tag' column of the messages pane. If I continue to try to remove the tags, I can get it down to a single tag. Sometimes the tags that are listed in the preview pane/header area do not match up with those reported in the Tag column. Occasionally, I can remove all tags.

How can I further confirm this bug? Would the names/versions of the exact mail servers be useful? I know one of the mail systems is titled Corvid. Both are in use at Carnegie Mellon University.

Comment 28

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 and my m.c imap account. 

Removing tags on Imap Messages is working fine on Thunderbird 2 RC 2.