342726 - Reduce nsSVGPatternFrame and nsSVGMaskFrame memory usage

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Can remove some member variables by passing parameters or getting data when required.

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[tor]

Comment on attachment 227047 [details] [diff] [review]
patch

>+PRUint16
>+nsSVGMaskFrame::GetMaskUnits()
>+{
>+  PRUint16 rv;
>+
>+  nsIDOMSVGMaskElement *maskElement = nsnull;
>+  CallQueryInterface(mContent, &maskElement);
>+  nsCOMPtr<nsIDOMSVGAnimatedEnumeration> units;
>+  maskElement->GetMaskUnits(getter_AddRefs(units));
>+  units->GetAnimVal(&rv);
>+  return rv;
>+}

You don't need to QI, as we know that mContent is a nsSVGMaskElement and can just be cast to that type.

>+PRUint16
>+nsSVGMaskFrame::GetMaskContentUnits()
>+{
...
>+}

Ditto.

Comment 3

[Robert Longson [:longsonr]]

Attachment: address review comments

Comment 4

[Robert Longson [:longsonr]]

Checked in.