342755 - Cmd-clicking javascript: links opens eternally "Loading..." tab

Status: RESOLVED INCOMPLETE

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Peter Jaros (:peeja)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060621 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060621 Camino/1.0+

Using tabbed browsing, if I Cmd-click a javascript: link a new tab opens to load that URL, just as with any link.  However, the javascript is generally useless in the new, blank tab.  These tabs have the title "Loading..." eternally.

True, I could make sure I don't try to open new tabs for javascript: links, but I use tabs so much I often don't notice, and some sites use javascript: urls for what I would expect to be normal links.

Reproducible: Always

Steps to Reproduce:
1. With tabbed browsing on, cmd-click the attached url (javascript:foo())
Actual Results:  
A tab opens called "Loading...", which never loads (understandably).

Expected Results:  
The javascript should have been executed in the context of the current page.

This may not be specific to tabbed browsing, but I couldn't reproduce it using new windows instead.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

The "get user-agent" bookmarklet always causes it in the same tab, no cmd-clicking needed.  See also bug 306396.

Comment 2

[Peter Jaros (:peeja)]

(In reply to comment #1)
> The "get user-agent" bookmarklet always causes it in the same tab, no
> cmd-clicking needed.  See also bug 306396.

Good point.  I think we may be talking about two different bugs.  One is the eternal "Loading..." behavior.  The other is loading javascript: urls in new tabs, which is arguably what I've told Camino to do, but is almost never a useful behavior and almost always (in my experience, always) a real pain.

Comment 3

[Håkan Waara]

What does Firefox do, Safari? Can you clarify what you mean by "executing the JS in the context of the current page"?

I mean, how would we know before clicking the link, what it does? It might open a new popup (in which case we can show it in a new tab somehow, I suppose) but it might also do something else AJAX-y, in which case we shouldn't open a new tab.

Comment 4

[Peter Jaros (:peeja)]

Can you think of a case where we'd *want* to open a new tab/window?  It would have to be a javascript snippet that generated its own content.  And no one would write a link like that because it would only work if you opened it in a new tab/window.  ;)

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass un-setting milestone per 1.6 roadmap.

Filter on RemoveRedonkulousBuglist to remove bugspam.

Developers: if you have a patch in hand for one of these bugs, you may pull the bug back to 1.6 *at that point*.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Given that the patch that was in bug 251137 was to browser/-specific code, this can't be a dupe.

Comment 8

[Dão Gottwald [:dao]]

The patch in bug 251137 is actually wrong, but yeah, I missed that this bug is specifically about Camino.

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

peeja's testcase now WFM; the "popup link" opens its pop-up, the "link" appends content to the page, and the data: link opens in a new tab.

WFM?