342763 - JavaScript errors in scripts in prefpanes not displayed in console

Status: RESOLVED DUPLICATE of bug 309814

(Toolkit :: Preferences, defect, P3)

Description

[Jeff Walden [:Waldo]]

This makes fixing bug 340677 a bit more annoying, although so far I've been lucky and mostly just had misplaced or missing commas in object literals which I can find without seeing a useful JS error for them

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Related to bug 324142 ?

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 241883 [details] [diff] [review]
patch

>Index: toolkit/content/widgets/preferences.xml

>+          var event = document.createEvent("Events");
>+          event.initEvent(aEventName, true, true);
>+
>+          // handle dom event handlers
>+          var noCancel = aTarget.dispatchEvent(event);
>+
>+          // handle any xml attribute event handlers
>+          var handler = aTarget.getAttribute("on" + aEventName))

extra ")", no ";"

>+          if (handler != "") {

Why not just if (handler)?

>+            var fn = new Function ("event", handler);
>+            var rv = fn.call(aTarget, event);
>+            if (rv == false)

Get rid of rv and just use |if (fn.call(aTarget, event) == false)| ?

>+              noCancel = false;
>           }
>-          return false;
>+          return noCancel;

Have you tested that any exceptions thrown by the handlers are properly reported? Maybe it's worth catching the exception here and using Component.utils.reportError with a more descriptive message?

Comment 4

[Asaf Romano (gone)]

*** This bug has been marked as a duplicate of 309814 ***