342774 - Search bar starts too high then resizes

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Every time when I start a branch browser it makes a jump. The toolbar gets higher because the searchbar gets higher.
Not the first start or the second but the third start after creating a new profile. Does not happen on a blank page so far.

A screenshot will make more clear what I mean.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot of the problem

Comment 2

[Bryan]

Confirmed with and without Add-ons! It's highly annoying.

BUILD: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1a3) Gecko/20060626 BonEcho/2.0a3 ID:2006062605

~B

Comment 3

[Ria Klaassen (not reading all bugmail)]

Regression between 1.8.1a3_2006061303 and 1.8.1a3_2006061404.
Weird that I didn't realize it before.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Commenting out http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/search/content/search.xml&rev=1.74&mark=291#287 fixes it, so setting the <xul:image>'s src attribute is what's causing the big jump. This is probably indirectly caused by the change from bug 337137, which added a better default image that had to be limited by a -moz-image-region. It seems like when we set the different icon, the -moz-image-region is temporarily removed and the search bar's size is increased to display the entire chrome://global/skin/icons/folder-item.png image, without actually displaying it.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Indeed, the search bar in the screenshot is 48 pixels high, which is the same height as chrome://global/skin/icons/folder-item.png (for windows).

Comment 6

[Ria Klaassen (not reading all bugmail)]

Sometimes I can't reproduce it. And I found out that it is not reproducible when these prefs are present:
user_pref("privacy.sanitize.didShutdownSanitize", true);
user_pref("privacy.sanitize.promptOnSanitize", false);
user_pref("privacy.sanitize.sanitizeOnShutdown", true);

Comment 7

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> Sometimes I can't reproduce it. And I found out that it is not reproducible
> when these prefs are present:
> user_pref("privacy.sanitize.didShutdownSanitize", true);
> user_pref("privacy.sanitize.promptOnSanitize", false);
> user_pref("privacy.sanitize.sanitizeOnShutdown", true);

Perhaps clearing the cache makes the image take longer to load, or something like that. Either way, I've found that explicitly specifying the height fixes this bug, I'll attach a patch.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Attachment: specify the height in CSS

Comment 9

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/winstripe/browser/searchbar.css 	1.12

Comment 10

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/winstripe/browser/searchbar.css 	1.3.8.8