ability for tinderbox to pull and unpack prebuilt binaries

RESOLVED FIXED

Status

Webtools Graveyard
Tinderbox
RESOLVED FIXED
12 years ago
4 years ago

People

(Reporter: rhelmer, Assigned: rhelmer)

Tracking

Details

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

12 years ago
Test-only tinderboxes should be able to download and unpack builds.

Ideally, this should live outside tinderbox - this will happen with the extracted test harness. For now though, it's in build-seamonkey-util and configurable via tinder-config.
(Assignee)

Comment 1

12 years ago
Created attachment 227137 [details] [diff] [review]
download and unpack prebuilt binary
Assignee: morgamic → rhelmer
Status: NEW → ASSIGNED
Attachment #227137 - Flags: review?(preed)

Comment 2

12 years ago
Comment on attachment 227137 [details] [diff] [review]
download and unpack prebuilt binary

Do you want to get the return values on the wget (to make sure it succeeded?)

Also, with -C, doesn't tar still need an operation? i.e. tar xfv -C $prebuilt $prebuilt/build.tgz)?
(Assignee)

Comment 3

12 years ago
Created attachment 227311 [details] [diff] [review]
download and unpack prebuilt binary

Sorry, I must have accidentally clobbered my changes before I did the last patch, here's a better one.
Attachment #227137 - Attachment is obsolete: true
Attachment #227311 - Flags: review?(preed)
Attachment #227137 - Flags: review?(preed)

Comment 4

12 years ago
Comment on attachment 227311 [details] [diff] [review]
download and unpack prebuilt binary

Please document what the variables mean in tinder-defaults.pl

Other than that, r=preed; good work!
Attachment #227311 - Flags: review?(preed) → review+
(Assignee)

Comment 5

12 years ago
Created attachment 227420 [details] [diff] [review]
use TestOnlyTinderbox var, comment tinder-defaults options
Attachment #227420 - Flags: review?(preed)

Comment 6

12 years ago
Comment on attachment 227420 [details] [diff] [review]
use TestOnlyTinderbox var, comment tinder-defaults options

change the mkdir call to a "mkdir -p" call.

Other than that, r=preed.
Attachment #227420 - Flags: review?(preed) → review+
(Assignee)

Updated

12 years ago
Attachment #227311 - Attachment is obsolete: true
(Assignee)

Comment 7

12 years ago
landed on trunk:

/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v  <--  build-seamonkey-util.pl
new revision: 1.321; previous revision: 1.320
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

12 years ago
Created attachment 227761 [details] [diff] [review]
logic is inverted; also make wget and tar less verbose
Attachment #227420 - Attachment is obsolete: true
Attachment #227761 - Flags: review?(preed)
(Assignee)

Updated

12 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Updated

12 years ago
Attachment #227761 - Flags: review?(preed) → review+
(Assignee)

Comment 9

12 years ago
Created attachment 227768 [details] [diff] [review]
same as previous patch, plus tell tinderbox to use downloaded binary
Attachment #227761 - Attachment is obsolete: true
Attachment #227768 - Flags: review?(preed)
(Assignee)

Comment 10

12 years ago
Created attachment 227769 [details] [diff] [review]
remove original binary_dir definition
Attachment #227768 - Attachment is obsolete: true
Attachment #227769 - Flags: review?(preed)
Attachment #227768 - Flags: review?(preed)

Updated

12 years ago
Attachment #227769 - Flags: review?(preed) → review+
(Assignee)

Comment 11

12 years ago
Checking in build-seamonkey-util.pl;
/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v  <-- 
build-seamonkey-util.pl
new revision: 1.325; previous revision: 1.324
done
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago12 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.