342783 - ability for tinderbox to pull and unpack prebuilt binaries

Status: RESOLVED FIXED

(Webtools Graveyard :: Tinderbox, defect)

Description

[Robert Helmer [:rhelmer]]

Test-only tinderboxes should be able to download and unpack builds.

Ideally, this should live outside tinderbox - this will happen with the extracted test harness. For now though, it's in build-seamonkey-util and configurable via tinder-config.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: download and unpack prebuilt binary

Comment 2

[J. Paul Reed [:preed]]

Comment on attachment 227137 [details] [diff] [review]
download and unpack prebuilt binary

Do you want to get the return values on the wget (to make sure it succeeded?)

Also, with -C, doesn't tar still need an operation? i.e. tar xfv -C $prebuilt $prebuilt/build.tgz)?

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: download and unpack prebuilt binary

Sorry, I must have accidentally clobbered my changes before I did the last patch, here's a better one.

Comment 4

[J. Paul Reed [:preed]]

Comment on attachment 227311 [details] [diff] [review]
download and unpack prebuilt binary

Please document what the variables mean in tinder-defaults.pl

Other than that, r=preed; good work!

Comment 5

[Robert Helmer [:rhelmer]]

Attachment: use TestOnlyTinderbox var, comment tinder-defaults options

Comment 6

[J. Paul Reed [:preed]]

Comment on attachment 227420 [details] [diff] [review]
use TestOnlyTinderbox var, comment tinder-defaults options

change the mkdir call to a "mkdir -p" call.

Other than that, r=preed.

Comment 7

[Robert Helmer [:rhelmer]]

landed on trunk:

/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v  <--  build-seamonkey-util.pl
new revision: 1.321; previous revision: 1.320
done

Comment 8

[Robert Helmer [:rhelmer]]

Attachment: logic is inverted; also make wget and tar less verbose

Comment 9

[Robert Helmer [:rhelmer]]

Attachment: same as previous patch, plus tell tinderbox to use downloaded binary

Comment 10

[Robert Helmer [:rhelmer]]

Attachment: remove original binary_dir definition

Comment 11

[Robert Helmer [:rhelmer]]

Checking in build-seamonkey-util.pl;
/cvsroot/mozilla/tools/tinderbox/build-seamonkey-util.pl,v  <-- 
build-seamonkey-util.pl
new revision: 1.325; previous revision: 1.324
done