342789 - No search box grippy/triangle in trunk builds with places

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Zach Lipton [:zach]]

After bug 337725 landed, the search engine selection icon is completely missing from the search box in trunk builds. If you happen to click in exactly the right spot, you can still access the menu, but the grippy/triangle isn't there. 

jminta thinks that the new icon is only built without places, so we should see about moving the icon into a new location.

Comment 1

[Joey Minta]

Yeah.  This is places only. http://lxr.mozilla.org/mozilla/source/browser/themes/pinstripe/browser/jar.mn#74

Comment 2

[Joey Minta]

Attachment: use places icon

Patch uses a Places icon if MOZ_PLACES is defined.

Comment 3

[(not reading, please use [e-mail] instead)]

joey, what do you think of doing it this way instead?

.search-go-button .toolbarbutton-menubutton-dropmarker {
%ifdef MOZ_PLACES
  list-style-image: url("chrome://browser/skin/places/folderDropArrow.png") !important;
%else
  list-style-image: url("chrome://browser/skin/bookmarks/folderarrow.png") !important;
%endif
}

Comment 4

[Joey Minta]

Attachment: use places icon v2

The mac I was using has temporarily disappear.  I'll test this shortly and then ask for review.

Comment 5

[Joey Minta]

Attachment: use places icon v3

Only ifdefs the actual url bit of the rule.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 228147 [details] [diff] [review]
use places icon v3

r=sspitzer

Comment 7

[Joey Minta]

Checking in browser/themes/pinstripe/browser/jar.mn;
/cvsroot/mozilla/browser/themes/pinstripe/browser/jar.mn,v  <--  jar.mn
new revision: 1.28; previous revision: 1.27
done
Checking in browser/themes/pinstripe/browser/searchbar.css;
/cvsroot/mozilla/browser/themes/pinstripe/browser/searchbar.css,v  <--  searchbar.css
new revision: 1.14; previous revision: 1.13
done