342914 - [FIX]RedirEntry should have a "flags" member instead of two boolean ones

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

from bug 341313:

 ------- Bug 341313 Comment #7 From Christian Biesinger (:bi)  2006-06-27 14:49 PDT  [reply] -------

(From update of attachment 226425 [details] [diff] [review] [edit])
-    { "neterror", "chrome://global/content/netError.xhtml", PR_TRUE }
+    { "neterror", "chrome://global/content/netError.xhtml", PR_TRUE, PR_TRUE }

have you considered making the third field a "flags" field instead, so that the
values are more self-documenting and that not all lines have to be changed for
a new flag?


------- Bug 341313 Comment #8 From Boris Zbarsky (gone June 26 -- Jul 13) 2006-06-27 15:13 PDT [reply] -------

Hmm...  I suppose I could do that, yeah... file a bug and I'll deal in July?

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch