342933 - Differentiate between tasks and events in day/week view

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Joey Minta]

In the month view, tasks get a *, to show that they're not events.  In the day/week view, they look the same.  We should fix that.

Comment 1

[Reed Loden [:reed]]

The bugspam monkeys have struck again. They are currently chewing on default assignees for Calendar. Be afraid for your sanity!

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Still happens with 1.0b1

Comment 3

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Comment 4

[Markus Adrario [:Taraman]]

Comment on attachment 432836 [details] [diff] [review]
Fix - v1

>diff --git a/calendar/base/content/calendar-view-core.xml b/calendar/base/content/calendar-view-core.xml
>--- a/calendar/base/content/calendar-view-core.xml
>+++ b/calendar/base/content/calendar-view-core.xml
>@@ -218,19 +218,22 @@
>           // something is added here, it should also be xbl:inherited correctly
>           // in the <content> section of this binding, and all that inherit it.
> 
>           // Event type specific properties
>           if (isEvent(item)) {
>               if (item.startDate.isDate) {
>                 this.setAttribute("allday", "true");
>               }
>+
>+              this.setAttribute("itemType", "event");
>           } else if (isToDo(item)) {
>               // progress attribute
>               this.setAttribute("progress", getProgressAtom(item));
>+              this.setAttribute("itemType", "todo");
>           }
> 
>           if (this.calendarView &&
>               item.hashId in this.calendarView.mFlashingEvents) {
>               this.setAttribute("flashing", "true");
>           }
>
>           if (alarms.length) {
Please delete added extra newline here.
You could also use this patch to change to cal.isEvent and cal.isToDo and to fix indentation after "if (item.startDate.isDate) {"

Otherwise patch looks good and works.
r=markus

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

Comments taken care of.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/933ffb84098a>

-> FIXED