342950 - crash when trying to print

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Firefox 2.0a3 crashes when trying to File->Print.
I've submitted a crash report with talkback id TB20356162W

It seems to be introduced with bug 324072

Please also see
https://bugzilla.novell.com/show_bug.cgi?id=187013

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Wolfgang, do you want to take this?

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

working on it

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch

The same has to go to 1.8 branch (the source file has been moved but the fix is the same.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 227508 [details] [diff] [review]
patch

Rob, maybe it's possible to get also sr from you for that?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 227508 [details] [diff] [review]
patch

oopsie

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

checked in to trunk:
Checking in nsPrintOptionsImpl.cpp;
/cvsroot/mozilla/widget/src/xpwidgets/nsPrintOptionsImpl.cpp,v  <--  nsPrintOptionsImpl.cpp
new revision: 1.84; previous revision: 1.83
done

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227508 [details] [diff] [review]
patch

Please check this in to trunk and let it bake before requesting branch approval. Thanks!

Comment 8

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 227508 [details] [diff] [review]
patch

no bustages on trunk since checkin

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 227508 [details] [diff] [review]
patch

cleared to land on runway 181

Comment 10

[Wolfgang Rosenauer [:wolfiR]]

branch checkin

Checking in gfx/src/nsPrintOptionsImpl.cpp;
/cvsroot/mozilla/gfx/src/Attic/nsPrintOptionsImpl.cpp,v  <--  nsPrintOptionsImpl.cpp
new revision: 1.76.2.2; previous revision: 1.76.2.1
done