[BeOS]re-enable EMULATE_BOLD

RESOLVED FIXED

Status

Core Graveyard
GFX: BeOS
RESOLVED FIXED
11 years ago
9 years ago

People

(Reporter: Sergei Dolgov, Assigned: Sergei Dolgov)

Tracking

({fixed1.8.1.8})

Trunk
x86
BeOS
fixed1.8.1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
There are some nice fonts which lack bold face, like Bitstream Cyberbit.
Previously we had little code which emulated bold face for such font by drawing string twice with +1 shift, but that was lost during big changes in our gfx.

Personally I feel lack of such feature now.
(Assignee)

Comment 1

11 years ago
Created attachment 227405 [details] [diff] [review]
patch

Old implementation had several issues - sometimes it emulated bold for fonts which actually have bold-face - that produced ugly results.
Also, emulation igonored visible width change, which lead sometimes to not so nice rendering in text with mixed bold and non-bold chars.

Both problems fixed in current implementation.
Also, to compensate little slowdown, there is attempt to use much more effetive B_OP_COPY mode wherever possible.

r=?
Assignee: beos → sergei_d
Status: NEW → ASSIGNED
Attachment #227405 - Flags: review?(thesuckiestemail)
(Assignee)

Comment 2

11 years ago
BeOS-only
Summary: re-enable EMULATE_BOLD → [BeOS]re-enable EMULATE_BOLD

Comment 3

11 years ago
Comment on attachment 227405 [details] [diff] [review]
patch

r=thesuckiestemail@yahoo.se
Looks fine to me.
Attachment #227405 - Flags: review?(thesuckiestemail) → review+
(Assignee)

Comment 4

11 years ago
Checking in mozilla/gfx/src/beos/nsFontMetricsBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsFontMetricsBeOS.cpp,v  <--  nsFontMetricsBeOS.cpp
new revision: 1.45; previous revision: 1.44
done
Checking in mozilla/gfx/src/beos/nsFontMetricsBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsFontMetricsBeOS.h,v  <--  nsFontMetricsBeOS.h
new revision: 1.14; previous revision: 1.13
done
Checking in mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp,v  <--  nsRenderingContextBeOS.cpp
new revision: 1.59; previous revision: 1.58
done 
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

10 years ago
Comment on attachment 227405 [details] [diff] [review]
patch

applies cleanly to 1.8.1.8 branch code
Attachment #227405 - Flags: approval1.8.1.8?
Comment on attachment 227405 [details] [diff] [review]
patch

BeOS-only change approved for 1.8.1.8, a=dveditz for release-drivers
Attachment #227405 - Flags: approval1.8.1.8? → approval1.8.1.8+
(Assignee)

Comment 7

10 years ago
Checking in mozilla/gfx/src/beos/nsFontMetricsBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsFontMetricsBeOS.cpp,v  <--  nsFontMetricsBeOS.cpp
new revision: 1.40.12.5; previous revision: 1.40.12.4
done
Checking in mozilla/gfx/src/beos/nsFontMetricsBeOS.h;
/cvsroot/mozilla/gfx/src/beos/nsFontMetricsBeOS.h,v  <--  nsFontMetricsBeOS.h
new revision: 1.12.12.2; previous revision: 1.12.12.1
done
Checking in mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp;
/cvsroot/mozilla/gfx/src/beos/nsRenderingContextBeOS.cpp,v  <--  nsRenderingContextBeOS.cpp
new revision: 1.51.12.7; previous revision: 1.51.12.6
done 
Keywords: fixed1.8.1.8
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.