342973 - Add facility for displaying simple EULA before install

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

I don't want a lot of knobs to twist here, just a way for us to put up something like

The creator of this add-on ($creator) requires that you agree to this license agreement before installing $addon:

<textarea disabled="true">...</textarea>

[Agree and Install] [Decline and Cancel]

I am more than fine with the only UI for adding such a EULA being in the administration area, rather being self-service by every add-on creator.

Comment 1

[Justin Scott [:fligtar]]

I added support for Privacy Policy and EULA on the public pages. Please see the following pages (with and without javascript):

Extension page with PP/EULA: https://update-staging.mozilla.org/~fligtar/v2-privacy/public/htdocs/firefox/3120

Extension page with multiple OSes PP/EULA: https://update-staging.mozilla.org/~fligtar/v2-privacy/public/htdocs/firefox/3121

Theme page with PP/EULA: https://update-staging.mozilla.org/~fligtar/v2-privacy/public/htdocs/firefox/3119

Do a search or visit any existing theme/extension if you'd like to make sure everything is the same if there's no PP/EULA set.

Main page (featured): https://update-staging.mozilla.org/~fligtar/v2-privacy/public/htdocs/
(2 featured extensions in rotation: one has PP/EULA, the other does not)

Recommended page: https://update-staging.mozilla.org/~fligtar/v2-privacy/public/htdocs/firefox/recommended/
(Again, one with EULA/PP and one without)

Please give me feedback about everything, and when it looks good I will re-update the developer portion of it and post again with the patch.

Thanks, Justin

Comment 2

[Cameron]

I would prefer the recommended and featured extensions to have links saying "get it" which point to the extension's addon.php page. The featured and recommended parts of the site don't provide the developer's description, developer comments, version notes, links to the extension's homepage, compatible apps, information about how to install in Thunderbird, or anything else, and it just seems like we're trying to tack everything onto the other pages when it really belongs in addon.php

fwiw, I can't seem to make it bring up your test extension as featured on the frontpage, only adblock.

Another thing I thought of - the EULA page doesn't have the giant box with how to install in thunderbird. I like the idea of having the eula in a textarea (as shaver suggested in c0) and then a checkbox saying "I have read and accept the EULA" and unless they check that, they can't click the install link. The problem with that is that I can't think of a way to do that if javascript is off.

While we're listing off problems - the other versions page doesn't prompt me to accept the EULA .

Comment 3

[Justin Scott [:fligtar]]

(In reply to comment #2)
> I would prefer the recommended and featured extensions to have links saying
> "get it" which point to the extension's addon.php page.
That's not a bad idea.

> fwiw, I can't seem to make it bring up your test extension as featured on the
> frontpage, only adblock.
It seems to have stopped rotating. Oh well, it works, I promise!

> Another thing I thought of - the EULA page doesn't have the giant box with how
> to install in thunderbird. I like the idea of having the eula in a textarea (as
> shaver suggested in c0) and then a checkbox saying "I have read and accept the
> EULA" and unless they check that, they can't click the install link. The
> problem with that is that I can't think of a way to do that if javascript is
> off.
I can add the TB box under the EULA for applicable addons. I'm pretty sure there's no way we could do the checkbox without javascript, so it would have to be Accept/Decline "buttons" there as well. I don't think the new page is such a huge inconvenience, and I don't think THAT many extensions will actually require you to accept their very own EULA/Terms of Use.
 
> While we're listing off problems - the other versions page doesn't prompt me to
> accept the EULA .
Yeah, I'm going to do that when I do the developers stuff. It will involve passing the version to eula.php so that it can pull the correct EULA for that version. I'm thinking same with the Privacy Policy.

Comment 4

[Wil Clouser [:clouserw]]

Fixed in v3