343084 - Warning text should be shorter, point to mozilla.com anti-phishing FAQ pages

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

The text in the warning bubble for anti-phishing should be reviewed for clarity and tone to make sure it fits with other Firefox messages. Also, the links need to be reviewed and updated to point to mozilla.com pages. An open question is whether or not the warning message itself needs to point to antiphishing.org or not.

See bug 329724 for the l10n issues related to this warning bubble.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: the current warning bubble

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: text changes for bubble

I *think* that I'm making the right XUL modifications to go along with the text changes here. I've also updated the URL for the link to more about anti-phishing to point to the mozilla web site as requested in the XXX comments.

The new text is:

(-) Suspected Web Forgery

This page has been reported as a web forgery, designed to trick users into sharing personal or financial information. Entering any personal information on this page may result in identity theft or other fraud.  

_Read more..._

These types of web forgeries are used in scams known as phishing attacks, in which fraudulent web pages and emails are used to imitate sources you may trust. You can _find out more about how Firefox protects you_ from phishing attacks.

If you believe this page has been falsely reported as a web forgery, you can _let us know_.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: text changes for bubble

Bah, forgot to rev the entity names ...

Comment 4

[Reed Loden [:reed]]

Comment on attachment 227812 [details] [diff] [review]
text changes for bubble

<gavin|> beltzner: you forgot to diff browser/locales in your latest patch to bug 343084

Comment 5

[Reed Loden [:reed]]

Comment on attachment 227806 [details] [diff] [review]
text changes for bubble

>+<!ENTITY safeb.palm.message.part1 "This page has been reported as a web forgery, designed to trick users into sharing personal or financial information. Entering any personal information on this page may result in identity theft or other fraud. &#160;">

The comma after "forgery" is extraneous. ;)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Huh. I'm about to head off grid for Canada Day weekend. Anyway I can convince an American to fix my boo-boo?

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: new bubble text for warning

revved entity names, removed extraneous comma, diff'd both files

Comment 8

[Mike Schroepfer]

What's next steps here?

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

(Dunno why Tony wasn't cc'd on this, oops, my bad.)

Next steps: get this landed and smoketested on trunk. Would be nice to have it in beta1, but can get sloughed off to beta2 if needs be. Seems like a simple, low-risk fix to new functionality, though.

Comment 10

[Axel Hecht [:Pike]]

Comment on attachment 228145 [details] [diff] [review]
new bubble text for warning

>+<!ENTITY safeb.palm.showmore.readmore "Read more ...">

should '...' be &hellip;?

>+<!ENTITY safeb.palm.message.para2 "These types of web forgeries are used in scams known as phishing attacks, in which fradulent web pages and emails are used to imitate sources you may trust. You can ">
>+<!ENTITY safeb.palm.message.link2.phishing.ffx "find out more about how Firefox protects you">
>+<!ENTITY safeb.palm.message.link2.url "http://www.mozilla.org/projects/bonecho/anti-phishing/">
>+
>+<!ENTITY safeb.palm.message.para3 " from phishing attacks.">

That's really para2.end, and could we make the para2 be para2.start?
>+
>+<!ENTITY safeb.palm.message.para4 "If you believe this page has been falsely reported as a web forgery, you can ">
>+<!ENTITY safeb.palm.message.link4.tellus "let us know">
>+<!ENTITY safeb.palm.message.para4.dot ".">

This is para3.start, link3.tellus and para3.end

The .dot entities are a tad confusing, as are the paragraphs spanning para entities. The text entities for the paragraphs should really be named independent of their english value, and use one number per paragraph.

What should we do with link2.url for l10n?

Sorry for the late comments, there are a few tsunamis in my vicinity and not all of them are soccer balls, sadly.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #10)

Coming up with a new patch to address your nits.

> What should we do with link2.url for l10n?

I think this becomes part of your larger "what do we do with l10n URLs" discussion in dev.planning, and shouldn't block this release. The URL will have to change in the future anyway to not be part of mozilla.org. My main goal with this patch is to get the strings in place for the l10n work to happen on it for beta2.

> Sorry for the late comments, there are a few tsunamis in my vicinity and not
> all of them are soccer balls, sadly.

No worries.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: new bubble text with l10n's nits adressed (revved entities again)

Here's the patch with Axel's nits addressed; I revved the entities again so that they're all making sense and following a logical scheme, but there's actually no change to the strings.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: text changes for bubble (nits addressed, typo fixed)

Oops, fixed a typo, carrying over r=gavin. This has been tested on branch, fwiw. It's impossible to test on trunk due to a current bug that prevents the SafeBrowsing bubble from being shown. I'll attach screenshots of what this patch does to branch.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: new warning bubble (basic mode)

Comment 15

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: new warning bubble (expanded mode)

Comment 16

[Axel Hecht [:Pike]]

From an l10n POV, the new code looks much nicer, thanks.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Attachment: text changes for bubble (nits addressed, typo fixed)

(carrying over r=gavin, turns out that I accidentally nuked a CR/LF that left a space in there, just a cosmetic fix)

Comment 18

[u88484]

*** Bug 339032 has been marked as a duplicate of this bug. ***

Comment 19

[Myk Melez [:myk] [@mykmelez]]

Landed on the 1.8 branch.

Comment 20

[Cédric Corazza]

Hi,
Shouldn't this entity : <!ENTITY safeb.palm.message.p2.linkText "how Firefox protects you"> have to be replaced with : <!ENTITY safeb.palm.message.p2.linkText "how &brandShortName; protects you"> ?

Comment 21

[u60234]

Comment on attachment 228268 [details] [diff] [review]
text changes for bubble (nits addressed, typo fixed)

>Index: browser/locales/en-US/chrome/browser/safebrowsing/phishing-afterload-warning-message.dtd
>===================================================================

>+<!ENTITY safeb.palm.message.p2.start "These types of web forgeries are used in scams known as phishing attacks, in which fradulent web pages and emails are used to imitate sources you may trust. You can find out more about ">

s/fradulent/fraudulent/?

Comment 22

[Mike Beltzner [:beltzner, not reading bugmail]]

Filed follow up bug 346049, re-resolving this one as fixed.

Comment 23

[Tony Chang (Google)]

This never got landed on trunk.  I'm going to do that right now . . .

Comment 24

[Tony Chang (Google)]

on trunk