Closed
Bug 343090
Opened 19 years ago
Closed 19 years ago
The "toolbar-menu-button" binding of Winstripe isn't used
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: asaf, Assigned: asaf)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.42 KB,
patch
|
kevin
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
(Found this while writing the testcase for bug 343037)
The "toolbar-menu-button" binding in browser.xml (Winstripe version) isn't used, thus I think we can drop it.
|
Assignee | |
Updated•19 years ago
|
Severity: normal → minor
Target Milestone: --- → Firefox 2 beta2
|
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #227517 -
Flags: review?(mconnor)
|
|
Assignee | |
Updated•19 years ago
|
Assignee: nobody → bugs.mano
|
|
Assignee | |
Updated•19 years ago
|
Attachment #227517 -
Flags: review?(mconnor) → review?(kevin)
|
||
Updated•19 years ago
|
Attachment #227517 -
Flags: review?(kevin) → review+
|
|
Assignee | |
Updated•19 years ago
|
Attachment #227517 -
Flags: approval1.8.1?
|
||
Comment 2•19 years ago
|
||
Comment on attachment 227517 [details] [diff] [review]
patch
a=drivers, please checkin on the 181 branch.
Attachment #227517 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Comment 3•19 years ago
|
||
1.8 branch:
Checking in browser/themes/winstripe/browser/browser.xml;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.xml,v <-- browser.xml
new revision: 1.4.8.1; previous revision: 1.4
done
Keywords: fixed1.8.1
Could this have caused the new extra padding around the forward and backward toolbar icons? There is much more between yesterdays and todays builds.
~B
|
|
Assignee | |
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•