343163 - DOM storage management interfaces (for embedders, add-ons, etc.)

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

Like for cookies (nsICookieManager), embedders need access to the DOM storage, so they can:
- enumerate sites that have data stored
- enumerate stored items for a given site
- query how much data a given site has stored
- limit the amount of data a given site can store
- delete some or all items for a given site
- delete all items from all sites

Comment 1

[Robert Kaiser]

What comment #0 says is something I almost filed another bug for, titled "management interfaces for DOM Storage" - I'm not an "embedder", but for my work on a web storage panel for Data Manager (add-on / SeaMonkey built-in) in bug    588415, it would be very helpful not to read the database directly, but have a reasonable interface for getting a list of all sites that employ DOM storage and get all items they have stored, including possibilities to manage/remove them.

Adjusting summary to reflect that this is not just for embedders.

I guess having those methods (on nsIDOMStorageManager perhaps?) would also ease work on bug 489444, as tests for those things might want to check correctness or clean up afterwards via some of those. Also, work on bug 343163 probably would be easier if it was easy to enumerate sites/items stored. I still need to take a look what workaround bug 339445 used for this...

Comment 2

[Robert Kaiser]

Oh, and just as a note (haven't checked yet, as I'm not there with my implementation yet), if there's no events one can observe for adding/removal/etc. of DOM storages, we probably want them as well, just like cookies, permissions, passwords, etc. have them.

Comment 3

[Josh Matthews [:jdm]]

There are DOM events as well as observer notifications for storage changes.

Comment 4

[Honza Bambas (:mayhemer)]

(In reply to comment #3)
> There are DOM events as well as observer notifications for storage changes.

Yes, see nsGlobalWindow::Observer and "dom-storage-changed" (globalStorage) and "dom-storage2-changed" (sessionStorage, localStorage with interface nsIDOMStorageEvent).

Comment 5

[Robert Kaiser]

(In reply to comment #3)
> There are DOM events as well as observer notifications for storage changes.

Thanks to you and Honza, I'm implementing the live changes with this, then. :)

The base problem that there's no way to enumerate all DOM storages remains, and this is mostly what this bug is about (though I currently query SQLite directly as a workaround).

Comment 6

[Honza Bambas (:mayhemer)]

You need to enumerate "active" storage objects or just all data in the database?  For the letter there is no api except direct sql access, as you do.  We may move this to the dom storage manager to use the existing connection.  It could potentially as part of this bug, but I plan to rewrite the localStorage code a bit, so we should sync our work.  However, the db struct (and more or less also the code location) will remain intact.

Comment 7

[Robert Kaiser]

(In reply to comment #6)
> You need to enumerate "active" storage objects or just all data in the
> database?

The Data Manager needs to list all domains that have any entries in storage. Maybe in the future it might even look into the stored data itself, but right now, all I need to get out of there is a list of all hosts for which anything is stored. For reference, the enumerator on nsICookieManager is how I get all needed info for cookies, would be nice to have something like that or like getAllLogins() in nsILoginManager.

Comment 8

[Robert Kaiser]

Oh, another interesting feature might be to expose the DB connection, like e.g. the Download Manager does. But not sure how easy/useful that is here.

Comment 9

[Honza Bambas (:mayhemer)]

Any one feel free to take this.

Comment 10

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.